Skip to content

Conversation

@mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Aug 5, 2025

Proposed change

Create an issue (which will become a repair) when disk lifetime has exceeded 90%.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

@mdegat01 mdegat01 added new-feature A new feature needs-client-library Pull requests needs client library changes but none is linked labels Aug 5, 2025
@mdegat01
Copy link
Contributor Author

mdegat01 commented Aug 5, 2025

Hm we need a new label. Something like needs-repair or needs-core to denote that this requires at least translation work in core. In this case a small amount of code too to enable the issue type to be made into a repair.

@agners agners changed the title Add an issue for disk lifetime >90% Add an issue for disk lifetime >=90% Aug 6, 2025
@agners
Copy link
Member

agners commented Aug 6, 2025

Hm we need a new label. Something like needs-repair or needs-core to denote that this requires at least translation work in core. In this case a small amount of code too to enable the issue type to be made into a repair.

Good point, created a new label needs-core for this.

@agners agners added the needs-core Pull request needs Home Assistant Core changes but none are linked label Aug 6, 2025
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agners agners merged commit fdde95d into main Aug 6, 2025
26 checks passed
@agners agners deleted the issue-for-disk-lifetime branch August 6, 2025 08:40
@mdegat01 mdegat01 removed the needs-client-library Pull requests needs client library changes but none is linked label Aug 6, 2025
@mdegat01 mdegat01 removed the needs-core Pull request needs Home Assistant Core changes but none are linked label Aug 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants