Skip to content

Conversation

@mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Aug 27, 2025

Proposed change

Enable background update/install of Home Assistant and Addons. This way Home Assistant can listen in for progress updates on install/addon and present that to the user

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

@mdegat01 mdegat01 requested a review from agners August 27, 2025 03:04
@mdegat01 mdegat01 added the new-feature A new feature label Aug 27, 2025
@home-assistant home-assistant bot marked this pull request as draft August 27, 2025 14:13
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mdegat01 mdegat01 marked this pull request as ready for review August 27, 2025 20:52
@home-assistant home-assistant bot requested a review from agners August 27, 2025 20:52
@mdegat01 mdegat01 force-pushed the background-install-update branch from 6d0f133 to b12d676 Compare September 2, 2025 20:11
@mdegat01
Copy link
Contributor Author

mdegat01 commented Sep 2, 2025

@agners refactored to use a specific validation_complete asyncio.Event as an arg rather then looking for bus events.

@mdegat01 mdegat01 added missing-documentation Added to pull requests that needs a docs, but none is linked needs-client-library Pull requests needs client library changes but none is linked labels Sep 2, 2025
Copy link
Member

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! I like this explicit synchronization using asyncio.Event much more.

@agners agners merged commit 9392d10 into main Sep 3, 2025
25 checks passed
@agners agners deleted the background-install-update branch September 3, 2025 06:33
@mdegat01 mdegat01 removed the needs-client-library Pull requests needs client library changes but none is linked label Sep 4, 2025
@mdegat01 mdegat01 removed the missing-documentation Added to pull requests that needs a docs, but none is linked label Sep 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Background option for install/update

3 participants