Fix getting Supervisor IP address in testing #6564
Open
+6
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Docker versions (probably newer than 29.x) do not have a global IPAddress attribute under .NetworkSettings anymore. There is a network specific map under Networks. For our case the hassio has the relevant IP address. This network specific maps already existed before, hence the new inspect format works for old as well as new Docker versions. While at it, also adjust the test fixture.
Member
Author
|
It seems the top-level properties got deprecated a long time ago 😅 |
agners
force-pushed
the
fix-get-supervisor-ip-address
branch
2 times, most recently
from
daf31b6 to
f5a9e1e
Compare
agners
force-pushed
the
fix-get-supervisor-ip-address
branch
from
f5a9e1e to
c2b7108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Newer Docker versions (probably newer than 29.x) do not have a global IPAddress attribute under .NetworkSettings anymore. There is a network specific map under Networks. For our case the hassio has the relevant IP address. This network specific maps already existed before, hence the new inspect format works for old as well as new Docker versions.
This fixes recent failures in GitHub Actions, caused by the ongoing
20260209image roll out, which contains Docker 29.1.5 (see the 20260209 image readme). Before the bundled Docker version was 28.0.4.While at it, also adjust the test fixture to reflect the removed network information.
Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed: