server-side rendering fixups#39
Open
PhilipTrauner wants to merge 1 commit intohome-assistant:nextfrom
Open
Conversation
Member
|
Can you upstream these fixes? |
bramkragten
approved these changes
Feb 26, 2026
Member
|
@PhilipTrauner please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a couple webawesome components are currently unavailable in Lit's server-side rendering context because they call unavailable methods
thankfully we aren't the first ones running into this issue
tldr.: page, button, and drawer all call methods that are unavailable in an SSR context (can't include a fix for page, as it is pro only)
there is a pending Lit PR that adds more fully-featured
EventTargetsupport, which removes the need to suppressaddEventListenerandremoveEventListenercallschildNodesandquerySelectorremain unsupported, which are required forHasSlotControlleri don't have enough experience with webawesome to know how big of a deal it is to effectively stub out all
HasSlotControllerfunctionalitythere isn't a lot of surface area to evaluate against in the device database (a single occurrence of button to be precise 🙈), but so far i did not run into any hydration mismatches
this isn't to say that they won't happen, but i think tackling those as our surface area increases is better than being blocked from using important components like
<wa-button>outright 😅none of these changes affect client-side rendered usage