Add support for Govee H5109 floating temperature sensor as a Thermostat#1082
Merged
bwp91 merged 2 commits intohomebridge-plugins:latestfrom Apr 13, 2025
Merged
Add support for Govee H5109 floating temperature sensor as a Thermostat#1082bwp91 merged 2 commits intohomebridge-plugins:latestfrom
bwp91 merged 2 commits intohomebridge-plugins:latestfrom
Conversation
…del as a thermostat and updating constants. Include new device type for H5109 in device index.
Collaborator
|
Looks good @nrc2358 thanks for taking the time to do this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of my last PR because I submitted it with the H5109 as a temp sensor instead of a thermostat which I found to be less useful.
This pull request adds support for the Govee H5109 floating pool temperature sensor to the homebridge-govee plugin.
I've added a new device file (sensor-thermo-H5109.js) and made the necessary changes to constants.js, platform.js, and device/index.js to integrate this sensor type. The implementation allows the device to appear as a thermostat in HomeKit. I used a thermostat instead of a temperature sensor so it shows as a block on the home summary.
I want to apologize if any part of my submission is outside the norm or doesn't follow best practices. This is my first time really coding something, much less contributing to GitHub, so I'm still learning the proper workflows and coding standards.
I've tested this implementation by copying the code to my personal homebridge server where I'm using the H5109 floating sensor. The sensor successfully connects and reports temperature data to HomeKit.
Thank you for considering my contribution to this project!