Conversation
…er of HomeKit camera streaming events occur simultaneously. (#1037)
…ug and error logging. (#1040)
* AdaptiveLightingController on update should provide some data without the need to build it yourself * Fix TypeError * Fixed linting and test issues * Typedoc fixes * Updated examples * Eslint fixes --------- Co-Authored-By: Tadeusz Wyrzykowski <shaquu@icloud.com>
* BridgedCore.ts and Core.ts cleanup (updated deprecation date from year 2022 to 2024). * Removed not allowed char from Sprinkler accessory example * Code review remarks Co-Authored-By: Tadeusz Wyrzykowski <shaquu@icloud.com>
Co-Authored-By: Donavan Becker <beckersmarthome@icloud.com>
…1051) Co-Authored-By: hjdhjd <hjdhjd@users.noreply.github.com>
Co-Authored-By: hjdhjd <hjdhjd@users.noreply.github.com>
…al edge case. (#1056) Co-Authored-By: hjdhjd <hjdhjd@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the latest branch with changes from release‑0.x, updating several modules, tests, and dependency definitions. Key changes include replacing inline ESLint suppression comments with explicit conditional statements, adjusting value rounding logic in Characteristic.ts with new tests for validateUserInput, and updating dependency versions and scripts in package.json.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/model/ControllerStorage.ts | Replaced inline ESLint suppression with an explicit if-check for data storage. |
| src/lib/definitions/generate-definitions.ts | Added type annotations using any with ESLint disable/enable comments for plist reads. |
| src/lib/camera/RTPStreamManagement.ts | Converted inline callback calls into explicit if-checks before invocation. |
| src/lib/Characteristic.ts | Changed numericMax declaration to let and adjusted its recalculation logic in the step adjustment block. |
| src/lib/Characteristic.spec.ts | Added tests to verify correct behavior of validateUserInput with value quantization. |
| src/lib/Accessory.ts | Updated multiple inline expressions to explicit if-checks to improve readability. |
| src/index.ts | Removed an unnecessary ESLint disable comment regarding require usage. |
| package.json | Updated several dependency versions and introduced a new generate-definitions script. |
| CHANGELOG.md | Updated version numbers and improved the changelog formatting. |
Pull Request Test Coverage Report for Build 15513709017Details
💛 - Coveralls |
donavanbecker
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR synchronizes the latest branch with changes from release‑0.x, updating several modules, tests, and dependency definitions. Key changes include replacing inline ESLint suppression comments with explicit conditional statements, adjusting value rounding logic in Characteristic.ts with new tests for validateUserInput, and updating dependency versions and scripts in package.json.
Show a summary per file