Skip to content

Add option to set retained config to /set topic #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add option to set retained config to /set topic #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5affda
Add option to set retained config to /set topic
labodj May 15, 2020
ec936e8
Fix for CircleCI lint.
labodj May 15, 2020
dc3a9b1
Merge branch 'develop' into feature-option-retain-set-topic
labodj Oct 30, 2020
4bbe3e4
Use MQTT qos 2 when /set topic is updated
labodj Dec 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/SendingPromise.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ SendingPromise::SendingPromise()
, _property(nullptr)
, _qos(0)
, _retained(false)
, _setRetained(true)
, _overwriteSetter(false)
, _range { .isRange = false, .index = 0 } {
}
Expand All @@ -21,6 +22,11 @@ SendingPromise& SendingPromise::setRetained(bool retained) {
return *this;
}

SendingPromise &SendingPromise::setSetRetained(bool retained) {
_setRetained = retained;
return *this;
}

SendingPromise& SendingPromise::overwriteSetter(bool overwrite) {
_overwriteSetter = overwrite;
return *this;
Expand Down Expand Up @@ -66,7 +72,7 @@ uint16_t SendingPromise::send(const String& value) {

if (_overwriteSetter) {
strcat_P(topic, PSTR("/set"));
Interface::get().getMqttClient().publish(topic, 1, true, value.c_str());
Interface::get().getMqttClient().publish(topic, 2, _setRetained, value.c_str());
}

delete[] topic;
Expand Down
2 changes: 2 additions & 0 deletions src/SendingPromise.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class SendingPromise {
SendingPromise();
SendingPromise& setQos(uint8_t qos);
SendingPromise& setRetained(bool retained);
SendingPromise& setSetRetained(bool retained);
SendingPromise& overwriteSetter(bool overwrite);
SendingPromise& setRange(const HomieRange& range);
SendingPromise& setRange(uint16_t rangeIndex);
Expand All @@ -34,6 +35,7 @@ class SendingPromise {
const String* _property;
uint8_t _qos;
bool _retained;
bool _setRetained;
bool _overwriteSetter;
HomieRange _range;
};
Expand Down