Merged
Conversation
stympy
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the notify method to return notice IDs, enabling callers to track which notices were successfully sent to Honeybadger. The change propagates the return value from the underlying send_notice call through the _send_notice and notify methods.
Changes:
- Modified
_send_noticeincore.pyto return the notice ID fromsend_notice - Added comprehensive tests for three scenarios: successful notification (returns ID), filtered notification (returns None), and excluded exception (returns None)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| honeybadger/core.py | Modified _send_notice to return the notice ID from successful send_notice calls |
| honeybadger/tests/test_core.py | Added three test cases validating return values for success, filtering, and exclusion scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add explicit return None for clarity in _send_notice early returns - Add tests verifying notify() returns notice_id or None appropriately - Fix black formatting issues in connection.py, test_core.py, utils.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
subzero10
approved these changes
Jan 30, 2026
subzero10
pushed a commit
that referenced
this pull request
Feb 1, 2026
🤖 I have created a release *beep* *boop* --- ## [1.1.1](v1.1.0...v1.1.1) (2026-01-30) ### Bug Fixes * return notice id from notify ([#232](#232)) ([a74ed0a](a74ed0a)), closes [#231](#231) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231