feat: remove Sidekiq server configuration from payloads#768
Open
feat: remove Sidekiq server configuration from payloads#768
Conversation
Remove extraction and transmission of Sidekiq server configuration (@options) from error payloads. This configuration data was: - Rarely useful for debugging individual job errors - Often very large (400+ lines with sidekiq-scheduler) - Mostly static server settings that don't help diagnose failures - Including Proc objects that couldn't serialize properly All job-specific debugging info (parameters, class, queue, retry count, stack trace) is still captured. Fixes #767
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the extraction and transmission of Sidekiq server configuration data from error payloads to address serialization issues and reduce payload size. The configuration data (extracted from @options instance variable) was rarely useful for debugging, often very large (400+ lines with sidekiq-scheduler), and contained non-serializable Proc objects.
- Removes conditional logic that extracted
@optionsfrom::Sidekiq::Configfor different Sidekiq versions - Retains all job-specific debugging information (parameters, class, queue, retry count, stack trace)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Henrik Nyh <henrik@nyh.se>
joshuap
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove extraction and transmission of Sidekiq server configuration (@options) from error payloads. This configuration data was:
All job-specific debugging info (parameters, class, queue, retry count, stack trace) is still captured.
Fixes #767