maint: switch to api dependency in build.gradle.kts#125
Open
MustafaHaddara wants to merge 2 commits intomainfrom
Open
maint: switch to api dependency in build.gradle.kts#125MustafaHaddara wants to merge 2 commits intomainfrom
api dependency in build.gradle.kts#125MustafaHaddara wants to merge 2 commits intomainfrom
Conversation
api dependency in build.gradle.ktsapi dependency in build.gradle.kts
a9d0d37 to
7d8259d
Compare
7d8259d to
b8c3386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Cleaning up our dependency declarations
Short description of the changes
Experimenting with
apidependencies in our gradle build.I am concerned about package/bundle sizes, but it looks like this change doesn't impact that much.
Here are the built artifacts on current
main:and with these changes:
And on our internal test app, the size of the build doesn't change either:
using the latest version from maven central, the app comes out to 20 mb:

using this version, built locally, the app comes out to 20 mb:

How to verify that this has the expected result