Skip to content

maint: switch to api dependency in build.gradle.kts#125

Open
MustafaHaddara wants to merge 2 commits intomainfrom
mh/gradle-deps
Open

maint: switch to api dependency in build.gradle.kts#125
MustafaHaddara wants to merge 2 commits intomainfrom
mh/gradle-deps

Conversation

@MustafaHaddara
Copy link
Contributor

@MustafaHaddara MustafaHaddara commented Jun 18, 2025

Which problem is this PR solving?

Cleaning up our dependency declarations

Short description of the changes

Experimenting with api dependencies in our gradle build.

I am concerned about package/bundle sizes, but it looks like this change doesn't impact that much.

Here are the built artifacts on current main:

$ ls -lh core/build/outputs/aar    
total 176
-rw-r--r--@ 1 mustafa  staff    43K Jun 18 11:29 core-debug.aar
-rw-r--r--@ 1 mustafa  staff    40K Jun 18 11:29 core-release.aar
$ ls -lh compose/build/outputs/aar 
total 32
-rw-r--r--@ 1 mustafa  staff   6.8K Jun 18 11:29 compose-debug.aar
-rw-r--r--@ 1 mustafa  staff   6.4K Jun 18 11:29 compose-release.aar
$ ls -lh interaction/build/outputs/aar
total 64
-rw-r--r--@ 1 mustafa  staff    15K Jun 18 11:30 interaction-debug.aar
-rw-r--r--@ 1 mustafa  staff    14K Jun 18 11:30 interaction-release.aar
$ ls -lh ~/.m2/repository/io/honeycomb/android/honeycomb-opentelemetry-android/0.0.0-DEVELOPMENT
total 168
-rw-r--r--@ 1 mustafa  staff    21K Jun 18 11:30 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT-sources.jar
-rw-r--r--@ 1 mustafa  staff    40K Jun 18 11:30 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT.aar
-rw-r--r--@ 1 mustafa  staff   5.7K Jun 18 11:30 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT.module
-rw-r--r--@ 1 mustafa  staff   4.6K Jun 18 11:30 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT.pom

and with these changes:

$ ls -lh core/build/outputs/aar
total 176
-rw-r--r--@ 1 mustafa  staff    43K Jun 18 10:25 core-debug.aar
-rw-r--r--@ 1 mustafa  staff    40K Jun 18 10:25 core-release.aar
$ ls -lh compose/build/outputs/aar 
total 32
-rw-r--r--@ 1 mustafa  staff   6.8K Jun 18 10:25 compose-debug.aar
-rw-r--r--@ 1 mustafa  staff   6.4K Jun 18 10:25 compose-release.aar
$ ls -lh interaction/build/outputs/aar
total 64
-rw-r--r--@ 1 mustafa  staff    15K Jun 18 10:25 interaction-debug.aar
-rw-r--r--@ 1 mustafa  staff    14K Jun 18 10:26 interaction-release.aar
$ ls -lh ~/.m2/repository/io/honeycomb/android/honeycomb-opentelemetry-android/0.0.0-DEVELOPMENT
total 168
-rw-r--r--@ 1 mustafa  staff    21K Jun 17 16:52 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT-sources.jar
-rw-r--r--@ 1 mustafa  staff    40K Jun 17 16:52 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT.aar
-rw-r--r--@ 1 mustafa  staff   5.7K Jun 17 16:52 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT.module
-rw-r--r--@ 1 mustafa  staff   4.6K Jun 17 16:52 honeycomb-opentelemetry-android-0.0.0-DEVELOPMENT.pom

And on our internal test app, the size of the build doesn't change either:

using the latest version from maven central, the app comes out to 20 mb:
image

using this version, built locally, the app comes out to 20 mb:
image

How to verify that this has the expected result

  • tests pass

  • CHANGELOG is updated
  • README is updated with documentation

@MustafaHaddara MustafaHaddara changed the title switch to api dependency in build.gradle.kts maint: switch to api dependency in build.gradle.kts Jun 18, 2025
@MustafaHaddara MustafaHaddara marked this pull request as ready for review July 31, 2025 12:56
@MustafaHaddara MustafaHaddara requested a review from a team as a code owner July 31, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant