Explain how ReceiveKeys are "special"#849
Open
stevenharman wants to merge 1 commit intohoneycombio:3.x-work-branchfrom
Open
Explain how ReceiveKeys are "special"#849stevenharman wants to merge 1 commit intohoneycombio:3.x-work-branchfrom
stevenharman wants to merge 1 commit intohoneycombio:3.x-work-branchfrom
Conversation
These `ReceiveKeys` are meant to be a list of the Honeycomb API keys that OTel clients have/send along with Spans. Then Refinery uses those to forward sampled Spans on to Honeycomb itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having a little trouble understanding exactly what
AccessKeys.ReceiveKeysare meant to be. From talking with Honeycomb folks in sour Slack, it sounds like they are a list of the Honeycomb API keys that OTel clients have/send along with Spans. Then Refinery uses those to forward sampled Spans on to Honeycomb itself.This change attempts to update the docs to reflect that more clearly.