perf(middleware): optimize route-check with WeakMap cache#4714
Open
BelovedYaoo wants to merge 1 commit intohonojs:feat/route-check-middlewarefrom
Open
perf(middleware): optimize route-check with WeakMap cache#4714BelovedYaoo wants to merge 1 commit intohonojs:feat/route-check-middlewarefrom
BelovedYaoo wants to merge 1 commit intohonojs:feat/route-check-middlewarefrom
Conversation
- Avoid redundant recursive handler checks for every request by caching the result.
4 tasks
BelovedYaoo
changed the title
BelovedYaoo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf(middleware): optimize route-check with WeakMap cache (for #4703)
Introduces a WeakMap cache to avoid redundant findTargetHandler and isMiddleware recursive checks on every request. Since handler identity is immutable at runtime, caching the result reduces overhead from O(depth) recursion to O(1) lookup.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code