-
Notifications
You must be signed in to change notification settings - Fork 279
feat(node-ws): allow custom http exception status code for node-ws #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 61c2690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
==========================================
- Coverage 92.24% 92.19% -0.05%
==========================================
Files 111 111
Lines 3661 3664 +3
Branches 956 958 +2
==========================================
+ Hits 3377 3378 +1
- Misses 250 251 +1
- Partials 34 35 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@krzysztofciombor-solidstudio Thank you for the PR. Hey @nakasyou ! What do you think of this? |
nakasyou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for late reply. It looks good!
yusukebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I fixed the changeset and the lint errors. Looks good to me. |
Description
Resolves #1573
Custom
HTTPException's status code thrown duringupgradeWebSocketwill be correctly reflected in the Websocket closed response codeThe author should do the following, if applicable
yarn changesetat the top of this repo and push the changeset