Skip to content

Conversation

@krzysztofciombor-solidstudio
Copy link
Contributor

Description

Resolves #1573

Custom HTTPException's status code thrown during upgradeWebSocket will be correctly reflected in the Websocket closed response code

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

🦋 Changeset detected

Latest commit: 61c2690

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/node-ws Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.19%. Comparing base (03e1a2c) to head (61c2690).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/ua-blocker/src/escape.ts 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1583      +/-   ##
==========================================
- Coverage   92.24%   92.19%   -0.05%     
==========================================
  Files         111      111              
  Lines        3661     3664       +3     
  Branches      956      958       +2     
==========================================
+ Hits         3377     3378       +1     
- Misses        250      251       +1     
- Partials       34       35       +1     
Flag Coverage Δ
node-ws 80.89% <100.00%> (+0.21%) ⬆️
ua-blocker 88.73% <0.00%> (-1.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe changed the title fix(1573): allow custom http exception status code for node-ws fix(node-ws): allow custom http exception status code for node-ws Nov 28, 2025
@yusukebe
Copy link
Member

@krzysztofciombor-solidstudio Thank you for the PR.

Hey @nakasyou ! What do you think of this?

Copy link
Contributor

@nakasyou nakasyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for late reply. It looks good!

@yusukebe yusukebe changed the title fix(node-ws): allow custom http exception status code for node-ws feat(node-ws): allow custom http exception status code for node-ws Jan 7, 2026
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jan 7, 2026

I fixed the changeset and the lint errors. Looks good to me.

@krzysztofciombor-solidstudio @nakasyou Thanks!

@yusukebe yusukebe merged commit 56f2f5a into honojs:main Jan 7, 2026
90 of 93 checks passed
@github-actions github-actions bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow custom HTTPException for node-ws upgrade

3 participants