fix: Avoid error if connection is aborted before internal request object is created #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hironao OTSUBO <[email protected]>
…ect is created At this time, since the user is not listening for abort events, so we should return immediately.
Member
Author
|
@yusukebe |
Member
|
Hey @usualoma honojs/hono#1695 was fixed by #223. But do we still need to merge this PR? |
Member
Author
|
Hi @yusukebe I think it would be better to merge this PR. It may not be a fatal error, but as in the test case, if the request becomes unstable very early after the connection, and ends with a timeout, the error still occurs. With this PR change, the existing standard case has no effect (no breaking change), so I think it would be better to merge it to avoid the error. |
yusukebe
approved these changes
Jan 31, 2025
Member
|
Thank you so much for the explanation! I understood. Merging and shipping a new version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes honojs/hono#1695
At this time, since the user is not listening for abort events, so we should return immediately.