fix: flush headers before sending data via readable stream #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hi @yusukebe! |
Member
|
Hey @usualoma ! Great! I've confirmed that it works correctly. Thank you! |
yusukebe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #244
Even if data is not immediately written from a ReadableStream, the header is sent without waiting for the data.
Is it sufficient to only handle ServerResponse?
Yes, in the case of Http2ServerResponse, there is no need to explicitly flush because the header is sent without waiting for the data.
Is this related to change #242?
No, it is not related. node-server has always behaved this way.