Skip to content

fix: better handle range parse to avoid NaN error #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yusukebe merged 4 commits into from
Sep 10, 2025
Merged

fix: better handle range parse to avoid NaN error #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd069b4
fix: better handle range parse to avoid NaN error
zwpaper Sep 9, 2025
d5f6d6c
fix the format error and add a test
yusukebe Sep 9, 2025
59a8919
remove unnecessary comment
yusukebe Sep 9, 2025
f68603d
remove the unnecessary logic
yusukebe Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/serve-static.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ export const serveStatic = <E extends Env = any>(
c.header('Date', stats.birthtime.toUTCString())

const parts = range.replace(/bytes=/, '').split('-', 2)
const start = parts[0] ? parseInt(parts[0], 10) : 0
let end = parts[1] ? parseInt(parts[1], 10) : stats.size - 1
const start = parseInt(parts[0], 10) || 0
let end = parseInt(parts[1], 10) || size - 1
if (size < end - start + 1) {
end = size - 1
}
Expand Down
7 changes: 7 additions & 0 deletions test/serve-static.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ describe('Serve Static Middleware', () => {
expect(res.text).toBe('This is plain.txt')
})

it('Should handle invalid range header gracefully without NaN error', async () => {
const res = await request(server).get('/static/plain.txt').set('range', 'hello')
expect(res.status).toBe(206)
expect(res.headers['content-length']).toBe('17')
expect(res.headers['content-range']).toBe('bytes 0-16/17')
})

it('Should handle the `onNotFound` option', async () => {
const res = await request(server).get('/on-not-found/foo.txt')
expect(res.status).toBe(404)
Expand Down
Loading