Skip to content

Comments

fix(build): preserve websocket export in bun adapter output#337

Merged
yusukebe merged 6 commits intohonojs:mainfrom
meck93:codex/bun-build-websocket-runtime-fix
Feb 13, 2026
Merged

fix(build): preserve websocket export in bun adapter output#337
yusukebe merged 6 commits intohonojs:mainfrom
meck93:codex/bun-build-websocket-runtime-fix

Conversation

@meck93
Copy link
Contributor

@meck93 meck93 commented Feb 13, 2026

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2026

🦋 Changeset detected

Latest commit: 6b23e7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/vite-build Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@meck93
Copy link
Contributor Author

meck93 commented Feb 13, 2026

hi @yusukebe I was about to write a message and create a Github issue but you were faster checking the PR than I could react 🤣 thanks!

@yusukebe yusukebe force-pushed the codex/bun-build-websocket-runtime-fix branch from aaad69e to 6b23e7b Compare February 13, 2026 14:01
@yusukebe
Copy link
Member

@meck93

🤣 Maybe this change 6b23e7b will fix the problem.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@meck93 Thanks!!

@yusukebe yusukebe merged commit a759e75 into honojs:main Feb 13, 2026
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 13, 2026
@meck93
Copy link
Contributor Author

meck93 commented Feb 13, 2026

@yusukebe yeah, sorry about that. I only saw it just now that I removed it as part of the initial commit: 32f6108#diff-35856020a3f7db59b2dfde867cd4e7f044f4b5995d4d6a7757af6eed8525c765L16 - most likely it was the linter or prettier. I didn't remove it on purpose. But either way thanks for merging 👍

@meck93 meck93 deleted the codex/bun-build-websocket-runtime-fix branch February 13, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants