[Helm Chart] Allow extra ConfigMap and Secret to be added to gateway chart envVars#1091
Open
nevarsin wants to merge 2 commits intohoophq:mainfrom
Open
[Helm Chart] Allow extra ConfigMap and Secret to be added to gateway chart envVars#1091nevarsin wants to merge 2 commits intohoophq:mainfrom
nevarsin wants to merge 2 commits intohoophq:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
Ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Allow an external Secret or ConfigMap to be added to the gateway Deployment envFrom.
Current implementation forces secrets to be set in clear text in values.yaml while this PR would enable scenarios where e.g. an existing external Secret Management solution is in charge of creating said Secret.
🔗 Related Issue
Fixes #
🚀 Type of Change
📋 Changes Made
🧪 Testing
Test Configuration:
Tests performed:
📸 Screenshots (if applicable)
✅ Checklist
📄 Additional Notes
Didn't run unit tests as app logic is untouched.