Skip to content

feat: add mandatory metadata#1302

Open
luanlorenzo wants to merge 23 commits intomainfrom
luan/eng-259-clean
Open

feat: add mandatory metadata#1302
luanlorenzo wants to merge 23 commits intomainfrom
luan/eng-259-clean

Conversation

@luanlorenzo
Copy link
Contributor

@luanlorenzo luanlorenzo commented Mar 3, 2026

📝 Description

This PR adds support for mandatory execution requirements across the terminal and runbooks flows, including setup, proactive UX warnings, and execution-time data collection.

🚀 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🎨 Style/UI update
  • ♻️ Code refactor
  • ⚡ Performance improvement
  • ✅ Test update
  • 🔧 Build configuration change
  • 🧹 Chore

📋 Changes Made

  • Added dynamic required metadata fields UI (add/remove/update field names).
  • Uses mandatory_metadata_fields from connection config/API.
  • Shows proactive callout when requirements exist (execution_requirements_callout).
  • Opens mandatory metadata modal prior to execution (mandatory_metadata_form).
  • Merges submitted required fields into execution metadata payload.
  • Shows proactive callout in runbooks runner.
  • Adds mandatory metadata pre-execution event flow.
  • Merges submitted required metadata into runbook execution payload.
  • Improved naming and shared usage across terminal and runbooks.
  • Minor UI polish (icon usage, heading/text styling, dismiss behavior).

🧪 Testing

Test Configuration:

  • Browser(s): Chrome
  • OS: MacOs

Tests performed:

  • Unit tests pass
  • Integration tests pass
  • Manual testing completed

📸 Screenshots

image image image

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@sandromello
Copy link
Contributor

✅ Build Completed with Success, Version=1302.0.0-01344e1

@sandromello
Copy link
Contributor

✅ Build Completed with Success, Version=1302.0.0-527d153

@sandromello
Copy link
Contributor

✅ Build Completed with Success, Version=1302.0.0-b878e3a

@luanlorenzo luanlorenzo marked this pull request as ready for review March 4, 2026 15:44
@sandromello
Copy link
Contributor

✅ Build Completed with Success, Version=1302.0.0-540afad

@sandromello
Copy link
Contributor

✅ Build Completed with Success, Version=1302.0.0-4c3281a

Base automatically changed from perotto/eng-258-mandatory-metadata-api to main March 4, 2026 18:41
Copy link
Contributor

@rogefm rogefm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the code yet, but I tested a few flows, and this is what I found:

  • The parallel mode flow needs improvements, as it just causes an error, and there's no feedback to the user on why
  • This flow doesn't work with JIRA when the JIRA template asks for custom inputs.
  • All the same happens in runbooks
Image Image

@luanlorenzo luanlorenzo requested a review from rogefm March 6, 2026 17:47
@sandromello
Copy link
Contributor

✅ Build Completed with Success, Version=1302.0.0-4b8935e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants