feat: Allow setting arbitrary max JIT session duration#869
Open
lekspyl wants to merge 1 commit intohoophq:mainfrom
Open
feat: Allow setting arbitrary max JIT session duration#869lekspyl wants to merge 1 commit intohoophq:mainfrom
lekspyl wants to merge 1 commit intohoophq:mainfrom
Conversation
Currently max sesstion duration is hardcoded to 48 hours. Users may want to set custom value. I'm adding a new `MAX_ACCESS_DURATION_HOURS` environment variable and using it in the `review.go` plugin. I'm not sure whether the `review.oss.go` file is used, so I've kept it intact
Member
|
hey @lekspyl sorry for hanging you here for so long. I will take this to the team and we will provide you with some feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently max sesstion duration is hardcoded to 48 hours. Users may want to set custom value.
I'm adding a new
MAX_ACCESS_DURATION_HOURSenvironment variable and using it in thereview.goplugin. I'm not sure whether thereview.oss.gofile is used, so I've kept it intact.