fix: properly cleanup related data when deleting connections#986
Open
andibeuge wants to merge 1 commit intohoophq:mainfrom
Open
fix: properly cleanup related data when deleting connections#986andibeuge wants to merge 1 commit intohoophq:mainfrom
andibeuge wants to merge 1 commit intohoophq:mainfrom
Conversation
- Fix DeleteConnection function to properly cleanup environment variables, plugin connections, and connection tags associations - Use database transaction to ensure atomicity of deletion operations - Add comprehensive test coverage for the DeleteConnection function - Environment variables were previously left orphaned in the database - Plugin connections were not being cleaned up - Connection tags associations were not being removed - Guard rail rules connections are automatically cleaned up via CASCADE constraint This fixes the bug where deleting a connection would leave related data orphaned in the database.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
andibeuge
commented
Aug 14, 2025
andibeuge
commented
Aug 14, 2025
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Member
|
hi @andibeuge, Mat from hoop here. Thanks for your contribution. Right now we have some design updates in parts related to your PR, so we will take this to a discussion inside, and we might hold this here for some weeks until we put all pieces together. Once we have everything sorted out, someone from the team will review this. If everything is in order, we will prepare the merge. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug where deleting a connection would leave related data orphaned in the database.
📝 Description
There seems to be a bug on deletion of connections - the env_vars remain in the database.
🔗 Related Issue
Fixes #
🚀 Type of Change
📋 Changes Made
🧪 Testing
Tests updated