Open
Conversation
- remove deprecated tasks - reduce optimization level to simple to prevent bugs - add target directory to the prod task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had troubles bootstrapping from this template, so I had to upgrade dependencies and fix some outdated tasks (see
boot --help | grep DEPRECATED). This setup seems to be working on Ubuntu 19.10, OpenJDK 14, as well as on Heroku.Unfortunately, it doesn't work with newer versions of Ring and Clojurescript. And I had to reduce the level of optimization to 'normal' to make it work in production on Heroku, not sure why this bug takes place.
Also, updated deployment instructions to work with new Heroku CLI Deploy plugin, as the old one is deprecated now.