Don't crash when Linode returns an invalid JSON#6
Open
Matheus28 wants to merge 1 commit intohoratio-sans-serif:masterfrom
Matheus28:patch-1
Open
Don't crash when Linode returns an invalid JSON#6Matheus28 wants to merge 1 commit intohoratio-sans-serif:masterfrom Matheus28:patch-1
Matheus28 wants to merge 1 commit intohoratio-sans-serif:masterfrom
Matheus28:patch-1
Conversation
Sometimes, because of 5xx errors, Linode doesn't actually return a JSON, but an error string. That causes linode-api to crash. This patch fixes this by forwarding an invalid JSON error to the callback. Please notice that I don't actually write in Coffeescript, but the code should be correct (it's equivalent to the change I made locally directly to the .js file to fix this).
Author
|
Actually, what is happening isn't exactly invalid JSON. But the Linode API replies with no body, and body = undefined, so it JSON.parse stringifies it and that's where the "invalid JSON" comes from. The fix still stands, though. |
horatio-sans-serif
force-pushed
the
master
branch
from
9d3ef43 to
7aec5df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, because of 5xx errors, Linode doesn't actually return a JSON, but an error string. That causes linode-api to crash. This patch fixes this by forwarding an invalid JSON error to the callback.
Please notice that I don't actually write in Coffeescript, but the code should be correct (it's equivalent to the change I made locally directly to the .js file to fix this).