This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Open
Conversation
horazont
added
work-in-progress
Previously, the code would force coercion of the value through the *nested* type (in most cases, String) first even if the value was already an enumeration member. This obviously breaks because the enumeration member is an instance of the Enumeration and not of any other type. This bug occurs only if deprecate_coerce is *false*, because otherwise there was an additional check for enum membership in the code path.
horazont
force-pushed
the
feature/mix
branch
from
385b7dc to
dfa3768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal for this PR is:
aioxmpp.mix, including a fat warning about the experimentalness of the code.Note that the implementation is tested against ejabberd 19.08, thus we’re not developing against the most recent MIX documents, but against the namespace versions
:core:0and:pam:0.MIX will be a nice experiment in how we handle namespace bumps in general.