feat: Align Kotlin JSON5 lexer with specification #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've implemented several enhancements and fixes to the JSON5 lexer to align it more closely with the official JSON5 specification: - Infinity & NaN Parsing: I've added support for parsing signed and unsigned Infinity and NaN values (e.g., +Infinity, -Infinity, NaN). - String Line Continuations: I've ensured that escaped line breaks (e.g., "\ ") in strings are correctly handled, treating them as zero-length. - Unicode Identifiers: I've expanded validation for unquoted object keys to support a wider range of Unicode characters as per ECMAScript 5.1 identifier rules (using Unicode character categories). - U+2028/U+2029 Warnings: I've set it up to issue warnings when unescaped U+2028 (Line Separator) or U+2029 (Paragraph Separator) characters are found in string literals, while still including them in the parsed value. - Whitespace Handling: I've added U+FEFF (Byte Order Mark) to the set of recognized whitespace characters. I've also added numerous corresponding unit tests for these features to JSON5ParseTest.kt. **Critical Note:** Due to persistent issues with the Gradle build environment (missing gradle-wrapper.jar, unable to bootstrap), I could not run and verify these changes and the full test suite. The implementation is based on code review and adherence to the specification but lacks automated test validation.
Owner
Author
Messed up the existing function! could not validate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented several enhancements and fixes to the JSON5 lexer to align it more closely with the official JSON5 specification:
I've also added numerous corresponding unit tests for these features to JSON5ParseTest.kt.
Critical Note: Due to persistent issues with the Gradle build environment (missing gradle-wrapper.jar, unable to bootstrap), I could not run and verify these changes and the full test suite. The implementation is based on code review and adherence to the specification but lacks automated test validation.