feat: add clear search field functionality on item select#767
Open
Sujalkumar12 wants to merge 1 commit intohossein-zare:dev-5.xfrom
Open
feat: add clear search field functionality on item select#767Sujalkumar12 wants to merge 1 commit intohossein-zare:dev-5.xfrom
Sujalkumar12 wants to merge 1 commit intohossein-zare:dev-5.xfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @hossein-zare ,
I noticed that there’s currently no functionality to clear the search field after selecting an item when both
multipleandsearchablearetrue.I recently implemented this feature in my project, and I believe it would be a valuable addition to our package as well. I also found some open issues related to this functionality:
Issue #622
Issue #750
In this PR, I’ve added a new prop called
clearSearchFieldOnSelect. This will clear the search field if the following conditions are met:clearSearchFieldOnSelectshould betruemultiple(picker) should betrueIf all conditions are satisfied,
clearSearchFieldOnSelectwill clear the search field.Please let me know if you have any feedback or if there are any changes needed!