Add additional verification method to the Postmark provider#31
Open
fsylum wants to merge 3 commits intohotmeteor:mainfrom
Open
Add additional verification method to the Postmark provider#31fsylum wants to merge 3 commits intohotmeteor:mainfrom
fsylum wants to merge 3 commits intohotmeteor:mainfrom
Conversation
Owner
|
@fsylum Thanks for your contribution! I think this is great. My only blocker on this is the config. I've tried to make it so that Receiver uses the existing So what I'd prefer is for it not to include a new config file but to instead look for these values in Hope that makes sense! |
Author
|
Thanks @hotmeteor for the feedbacks! I've removed the custom config file and updated the documentation section for the Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add additional verification methods to the Postmark provider.
Summary of changes:
Configurationsection.authwill retain the existing functionality.headerswill validate against configured header in Postmark webhook page.ipswill validate against the provided Postmark IP address on https://postmarkapp.com/support/article/800-ips-for-firewalls#webhooksFixes #7.
Please let me know what you think, thanks!