Skip to content

Conversation

@BlessingEmejulu
Copy link

@BlessingEmejulu BlessingEmejulu marked this pull request as draft June 7, 2025 21:42
@BlessingEmejulu BlessingEmejulu marked this pull request as ready for review June 7, 2025 21:42
@kshitijrajsharma
Copy link
Member

Thanks for the PR , will be moved to review

Copy link
Collaborator

@jeafreezy jeafreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work. This is so great! Thank you @BlessingEmejulu

@BlessingEmejulu could you please delete the node_modules and the cache/deps folders so we can have a cleaner PR for easier review?

Just delete it locally and push the updates and it should be gone.

Thank you once again!

@jeafreezy
Copy link
Collaborator

About the approach, do you think we should keep the docs in the frontend folder @kshitijrajsharma or it should be in the general docs folder at the root directory.

@BlessingEmejulu what do you think ?

@BlessingEmejulu
Copy link
Author

It should be in general docs

@jeafreezy
Copy link
Collaborator

jeafreezy commented Jun 20, 2025

It should be in general docs

Alright. Sounds great. I think I’ll lean towards that direction too.

Although I can see the current PR has the docs in the frontend sub folder. Can you recheck ? Perhaps that wasn’t intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add getting started , Developer friendly docs , Build docs using mkdocs and githubaction

3 participants