Feature - Add ghostty to aider desk by jutaz · Pull Request #613 · hotovo/aider-desk

jutaz · 2026-01-14T15:07:39Z

Adds ghostty via ghostty-web instead of xterm. This should increase reliability and usability of the inbuilt terminal.

gemini-code-assist · 2026-01-14T15:08:02Z

Summary of Changes

Hello @jutaz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant upgrade to the application's integrated terminal by replacing the existing xterm.js implementation with ghostty-web. This migration is intended to enhance the terminal's overall reliability and user experience. The changes span across dependency updates, adjustments to security policies, and a comprehensive refactoring of the terminal's frontend component to seamlessly integrate the new ghostty-web library.

Highlights

Terminal Library Switch: The core terminal functionality has been migrated from xterm.js to ghostty-web, aiming for improved reliability and usability of the inbuilt terminal.
Dependency Management: xterm.js and its associated addons (@xterm/addon-fit, @xterm/addon-web-links) have been removed from package.json, and ghostty-web has been added as a new dependency.
Content Security Policy Update: The index.html file's Content Security Policy (CSP) was adjusted to include 'unsafe-eval' for script-src and data: for connect-src, which are likely requirements for ghostty-web.
Terminal Component Refactor: The Terminal.tsx component has been significantly refactored to integrate ghostty-web, including changes to imports, state management, lifecycle effects, and exposed imperative methods.
Automatic Resizing & Cursor Handling: ghostty-web now handles terminal resizing automatically, removing the need for a FitAddon. Custom CSS was added to hide native cursors, as ghostty likely renders its own.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request replaces xterm.js with ghostty-web for the terminal component, which is a significant and welcome improvement for reliability and usability. The refactoring also includes performance enhancements for terminal tab switching. While the changes are generally positive, I've identified a critical bug that causes an infinite render loop, a high-severity security issue with the Content Security Policy, and a couple of medium-severity issues related to error handling and potential performance optimizations. Please review the comments for details.

src/renderer/src/components/terminal/Terminal.tsx

src/renderer/index.html

src/renderer/src/components/terminal/Terminal.tsx

wladimiiir · 2026-01-14T20:03:17Z

There are some issues I have found out during testing:

missing padding

cursor is disappearing when over it
missing scrollbar

terminal not focused automatically when opened

wladimiiir

See my comment.

jutaz · 2026-01-15T16:44:03Z

See my comment.

Good points, addressed 👍

wladimiiir

Looks better, my previous findings seem to have been fixed, but I am experiencing another issue when minimizing/closing the Terminal view when there are messages present. It seems that it does close the component area properly:

wladimiiir · 2026-01-28T08:30:25Z

@jutaz
Thanks for the update, almost there 🙂
There seems to be an issue, that when you open new terminal, it's not possible to write input into the previously created terminals anymore. Can you please have a look at it as well as the failing checks? Thank you.

jutaz · 2026-01-28T08:34:56Z

Taking a look in an hour or so - sorry about that! Focused on layout too much 😂

wladimiiir · 2026-03-11T10:29:20Z

@jutaz
Do you think you will have time to finish this one up in the next few days?

…dates

kilo-code-bot · 2026-03-12T16:10:40Z

src/renderer/src/components/terminal/Terminal.tsx

+    ghostty.onResize(({ cols, rows }) => {
+      void api.resizeTerminal(terminalId, cols, rows);
+    });
+  }, [terminalId, api, ghosttyTerminal]);


CRITICAL: Memory leak - event handlers not cleaned up

The onData and onResize event handlers registered on the ghostty terminal are never removed. This will cause memory leaks when the component unmounts or when dependencies change.

The effect should return a cleanup function that removes these handlers. Most terminal libraries provide an unsubscribe mechanism or disposable pattern for event handlers.

kilo-code-bot · 2026-03-12T16:10:40Z

src/renderer/src/components/terminal/Terminal.tsx


    void createTerminal();
-  }, [baseDir, terminalId, visible, api, taskId]);
+  }, [baseDir, terminalId, visible, api, taskId, ghosttyTerminal]);


WARNING: Missing dependency in useEffect

The fitAddon is used inside the effect (line 294) but is not included in the dependency array. This could cause the effect to use a stale reference to fitAddon.

Add fitAddon to the dependency array: [baseDir, terminalId, visible, api, taskId, ghosttyTerminal, fitAddon]

kilo-code-bot · 2026-03-12T16:10:40Z

src/renderer/src/components/terminal/Terminal.scss

+}
+
 .xterm-viewport {
  @apply scrollbar-thin scrollbar-track-bg-primary scrollbar-thumb-bg-secondary-light hover:scrollbar-thumb-bg-tertiary;


WARNING: Stale CSS selector after library migration

The .xterm-viewport class was specific to the xterm.js library which has been replaced with ghostty-web. This selector will no longer match any elements and should be updated to target ghostty-web's viewport class or removed if no longer needed.

Check ghostty-web documentation for the correct class names.

kilo-code-bot · 2026-03-12T16:10:40Z

src/renderer/src/components/terminal/Terminal.scss


 .xterm-screen {
-  @apply px-3;
+  @apply pl-3 pr-0;


WARNING: Stale CSS selector after library migration

The .xterm-screen class was specific to the xterm.js library which has been replaced with ghostty-web. This selector will no longer match any elements and should be updated to target ghostty-web's screen class or removed if no longer needed.

Check ghostty-web documentation for the correct class names.

kilo-code-bot · 2026-03-12T16:10:54Z

Code Review Summary

Status: 2 New Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	1
WARNING	1

New Issue Details (click to expand)

CRITICAL

File	Line	Issue
`src/renderer/src/components/terminal/Terminal.tsx`	272	Circular dependency in useLayoutEffect causing infinite re-renders

WARNING

File	Line	Issue
`src/renderer/src/components/terminal/Terminal.tsx`	318	Missing `fitAddon` dependency in useLayoutEffect

Previously Reported Issues (8 active)

File	Line	Issue
`src/renderer/src/components/terminal/Terminal.tsx`	345	CRITICAL: Memory leak - event handlers not cleaned up
`src/renderer/src/components/terminal/Terminal.tsx`	318	WARNING: Missing dependency in useEffect
`src/renderer/src/components/terminal/Terminal.scss`	N/A	WARNING: Stale CSS selector after library migration
`src/renderer/index.html`	N/A	Security issue

Files Reviewed (4 files)

package.json - Dependency changes (xterm → ghostty-web)
package-lock.json - Lock file updates
src/renderer/src/components/terminal/Terminal.tsx - 2 new issues
src/renderer/src/components/terminal/TerminalView.tsx - No new issues
src/main/terminal/terminal-manager.ts - No issues

Fix these issues in Kilo Cloud

kilo-code-bot · 2026-03-12T16:26:58Z

src/renderer/src/components/terminal/Terminal.tsx

+      }
    };
-  }, [terminalId, api]);
+  }, [taskId, visible, fitAddon]);


CRITICAL: Circular dependency causing infinite re-renders

The useLayoutEffect at line 124 includes fitAddon in its dependency array (line 272), but this same effect creates and sets fitAddon via setFitAddon(fitAddonInstance) at line 219. This creates a circular dependency:

Effect runs → creates new fitAddon → calls setFitAddon

fitAddon state changes → triggers effect again

Loop repeats infinitely

Impact: Infinite re-renders, memory leaks from repeatedly creating/disposing terminal instances, poor performance.

Solution: Remove fitAddon from the dependency array. The effect should only run when taskId or visible changes, not when fitAddon changes (since the effect itself creates it).

Suggested change

}, [taskId, visible, fitAddon]);

}, [taskId, visible]);

kilo-code-bot · 2026-03-12T16:26:58Z

src/renderer/src/components/terminal/Terminal.tsx


    void createTerminal();
-  }, [baseDir, terminalId, visible, api, taskId]);
+  }, [baseDir, terminalId, visible, api, taskId, ghosttyTerminal]);


WARNING: Missing fitAddon dependency in useLayoutEffect

The effect uses fitAddon at line 293-295 but doesn't include it in the dependency array. This violates the React hooks exhaustive-deps rule and could cause the effect to use a stale fitAddon reference.

Solution: Add fitAddon to the dependency array:

Suggested change

}, [baseDir, terminalId, visible, api, taskId, ghosttyTerminal]);

}, [baseDir, terminalId, visible, api, taskId, ghosttyTerminal, fitAddon]);

Add ghostty to aider desk

581da0d

github-actions bot requested a review from wladimiiir January 14, 2026 15:07

gemini-code-assist bot reviewed Jan 14, 2026

View reviewed changes

Address feedback

e445657

wladimiiir requested changes Jan 14, 2026

View reviewed changes

Fix issues and make terminal resizable

ae6431c

jutaz requested a review from wladimiiir January 15, 2026 16:44

wladimiiir requested changes Jan 17, 2026

View reviewed changes

jutaz and others added 2 commits January 28, 2026 00:07

Fix terminal visibility and resizable box.

edbb877

Merge branch 'main' into feature/ghostty

e50b72e

feat(terminal): enhance terminal component integration and manager up…

991477d

…dates

kilo-code-bot bot reviewed Mar 12, 2026

View reviewed changes

feat: terminal improvements and styling fixes

b6e84a2

kilo-code-bot bot reviewed Mar 12, 2026

View reviewed changes

	}, [baseDir, terminalId, visible, api, taskId, ghosttyTerminal]);
	}, [baseDir, terminalId, visible, api, taskId, ghosttyTerminal, fitAddon]);

Conversation

jutaz commented Jan 14, 2026

Uh oh!

gemini-code-assist bot commented Jan 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wladimiiir commented Jan 14, 2026

Uh oh!

wladimiiir left a comment

Choose a reason for hiding this comment

Uh oh!

jutaz commented Jan 15, 2026

Uh oh!

wladimiiir left a comment

Choose a reason for hiding this comment

Uh oh!

wladimiiir commented Jan 28, 2026

Uh oh!

jutaz commented Jan 28, 2026

Uh oh!

wladimiiir commented Mar 11, 2026

Uh oh!

kilo-code-bot bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Overview

CRITICAL

WARNING

Uh oh!

kilo-code-bot bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

kilo-code-bot bot Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kilo-code-bot bot commented Mar 12, 2026 •

edited

Loading