Improvement: Add support for includeClosed and assignedLocationId filters in get#FulfillmentOrdersByOrderId#188
Open
puru-khedre wants to merge 4 commits intohotwax:mainfrom
Open
Conversation
patelanil
reviewed
Sep 12, 2025
| @@ -391,14 +391,20 @@ | |||
| <fileData> | |||
| <![CDATA[<#ftl output_format="HTML"> | |||
| <@compress single_line=true> | |||
Contributor
There was a problem hiding this comment.
Can we exclude more than one status ?
excludeStatus(List)
If more than one status can be excluded, then name the variable excludeStatusList else excludeStatus
Contributor
Author
There was a problem hiding this comment.
Shopify supports multiple conditions,
but it does not support operators like in or not-in.
If we want to accept a list excluded status,
then we’ll need to join it using the OR or AND operator.
Example:
Suppose the excluded list has OPEN and CLOSED statuses.
In that case, we need to prepare the query as: query: "-status:OPEN AND -status:CLOSED"
Contributor
Author
There was a problem hiding this comment.
I agree that, instead of being tied to just one status, having an excludeStatus list would allow for better handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #181
This PR improves the
get#FulfillmentOrdersByOrderIdflow by adding support for two filters:includeClosed(Boolean, defaulttrue) → lets exclude/include the CLOSED fulfillment orders.assignedLocationId→ filters fulfillment orders assigned to a specific Shopify location (converted to GID via ShopifyHelper).Template updated to pass these as query params, so filtering happens at the API level.
Backward compatible with old behavior.
Changes:
ShopifyFulfillmentServices.xml.ShopifyTemplateData.xmlto include these filters.