Skip to content

Add an example for custom key mappings#850

Open
pdx91 wants to merge 1 commit intohotwired:mainfrom
pdx91:patch-1
Open

Add an example for custom key mappings#850
pdx91 wants to merge 1 commit intohotwired:mainfrom
pdx91:patch-1

Conversation

@pdx91
Copy link
Copy Markdown

@pdx91 pdx91 commented Jul 17, 2025

No description provided.

Comment on lines +109 to +114
keyMappings: {
...defaultSchema.keyMappings,
at: "@",
slash: "/",
question: "?"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this doesn't add much. The example below could use the existing at mapping.

Comment on lines +123 to +125
<div data-controller="search"
data-action="keydown.slash->search#focus keydown.question->search#showHelp">
</div>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div data-controller="search"
data-action="keydown.slash->search#focus keydown.question->search#showHelp">
</div>
<div data-controller="mentions"
data-action="keydown.at->mentions#displaySuggestions"></div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants