Fix activateScriptElement to set the CSP nonce correctly#1503
Open
mildred wants to merge 1 commit intohotwired:mainfrom
Open
Fix activateScriptElement to set the CSP nonce correctly#1503mildred wants to merge 1 commit intohotwired:mainfrom
mildred wants to merge 1 commit intohotwired:mainfrom
Conversation
The `activateScriptElement` function did not correctly set the CSP nonce on occasions. When the element to duplicate has been stripped from its CSP nonce in `elementWithoutNonce`, the nonce attribute is set to an empty string and would overwrite the correct nonce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
activateScriptElementfunction did not correctly set the CSP nonce on occasions. When the element to duplicate has been stripped from its CSP nonce inelementWithoutNonce, the nonce attribute is set to an empty string and would overwrite the correct nonce.Fix #1502