Skip to content

Fix clone with SPECIO_IMPLEMENTATION=PP#24

Merged
autarch merged 1 commit intohouseabsolute:masterfrom
arodland:fix-clone-implementation
Jun 21, 2025
Merged

Fix clone with SPECIO_IMPLEMENTATION=PP#24
autarch merged 1 commit intohouseabsolute:masterfrom
arodland:fix-clone-implementation

Conversation

@arodland
Copy link
Contributor

Passes dzil test except for precious (because I don't have all of the tools installed).

@arodland arodland force-pushed the fix-clone-implementation branch 2 times, most recently from adc3139 to d38ada5 Compare June 20, 2025 16:34
@autarch
Copy link
Member

autarch commented Jun 21, 2025

Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:

  1. I check it out locally, fiddle with it as needed, merge it locally, and simply close this PR. This will preserve at least one commit with your name on it, but the PR will show up as closed in your GitHub stats.
  2. If you enable me to push directly to your PR branch (which is the default when you make a PR), I can do my fiddling, then force push to your PR branch and merge the resulting PR. Again, this will preserve at least one commit with your name on it, but you also get credit for the PR merge in your GitHub stats. The only downside is that I will be force pushing directly to your PR branch. Note that this will not work if the PR branch is named master. GitHub doesn't allow me to push to the default branch of your fork.

Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1.

Thanks again for your contribution!

@arodland
Copy link
Contributor Author

2 is fine

@arodland
Copy link
Contributor Author

Either is fine 🙂

@autarch autarch force-pushed the fix-clone-implementation branch from d38ada5 to 3c9e292 Compare June 21, 2025 19:01
The changes in 0.51 did not address most direct uses of Clone, just the one in Specio::OO. Loading
Clone::Choose was accidentally added in 0.51, even though it was actually needed.
@autarch autarch force-pushed the fix-clone-implementation branch from 3c9e292 to c07ad42 Compare June 21, 2025 19:04
@autarch autarch merged commit 9ac2297 into houseabsolute:master Jun 21, 2025
7 checks passed
@arodland
Copy link
Contributor Author

arodland commented Aug 6, 2025

@autarch do you have time for a release?

@autarch
Copy link
Member

autarch commented Aug 9, 2025

@autarch do you have time for a release?

Oops, I meant to do this right after I merged this. I just released 0.52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants