Fix clone with SPECIO_IMPLEMENTATION=PP#24
Merged
autarch merged 1 commit intohouseabsolute:masterfrom Jun 21, 2025
Merged
Conversation
adc3139 to
d38ada5
Compare
Member
|
Hi, thanks for your PR! I'm pretty finicky about my projects (see this blog post for details), so I rarely merge a PR as-is. I can move forward on your PR in one of two ways:
Please let me know which approach you'd prefer. If I don't hear from you before I get around to working on this PR I'll go with option 1. Thanks again for your contribution! |
Contributor
Author
|
2 is fine |
Contributor
Author
|
Either is fine 🙂 |
d38ada5 to
3c9e292
Compare
The changes in 0.51 did not address most direct uses of Clone, just the one in Specio::OO. Loading Clone::Choose was accidentally added in 0.51, even though it was actually needed.
3c9e292 to
c07ad42
Compare
Contributor
Author
|
@autarch do you have time for a release? |
Member
Oops, I meant to do this right after I merged this. I just released 0.52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes
dzil testexcept for precious (because I don't have all of the tools installed).