Fix onboarding flow after deploying lockup contract #209
Draft
Fix onboarding flow after deploying lockup contract #209
Conversation
jcarnide
commented
Nov 5, 2025
| const retryFromCurrentStep = useCallback(() => { | ||
| executeTransactions({ | ||
| numTransactions: requiredTransactions.length, | ||
| startAt: transactionStep, |
Contributor
Author
There was a problem hiding this comment.
We should start at index 0 since requiredTransactions will get updated automatically to reflect the correct set of remaining steps after the cache is busted
📊 Test Coverage ReportOverall Coverage
📁 Detailed Coverage by File
📋 Show 144 more files...
Coverage Thresholds:
This report was generated by the Test Coverage workflow. |
jcarnide
commented
Nov 5, 2025
| queryKey: [ | ||
| READ_NEAR_CONTRACT_QK, | ||
| CONTRACTS.VENEAR_CONTRACT_ID, | ||
| "get_account_info", |
Contributor
Author
There was a problem hiding this comment.
Busting this cache means the assets page will immediately update without needing the user to refresh the page themselves.
This solves the UX issue where the user:
- Initiates onboarding and submits the txn to deploy their lockup
- Experiences an error during the lock txn (e.g. popup blocked) or abandons the flow
- Does not refresh the page
- Attempts to lock & stake again
Historically this would cause us to take the user through the full onboarding flow again assuming they don't have a lockup deployed, resulting in an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Changes
📦 Type of Change
Select one:
chore(maintenance, formatting, etc.)bug(fixes an issue)feature(adds new functionality)✅ Testing
📸 Screenshots (if applicable)