Skip to content

Comments

Copy Audit & Improvements #263

Open
atomauro wants to merge 3 commits intomainfrom
atom/copy-audit-improvements
Open

Copy Audit & Improvements #263
atomauro wants to merge 3 commits intomainfrom
atom/copy-audit-improvements

Conversation

@atomauro
Copy link
Contributor

@atomauro atomauro commented Feb 9, 2026

No description provided.

@atomauro atomauro self-assigned this Feb 9, 2026
@atomauro atomauro added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 9, 2026
@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hos-agora-near Ready Ready Preview, Comment Feb 16, 2026 0:24am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 9, 2026 •
edited
Loading

📊 Test Coverage Report

Overall Coverage

Metric Coverage Threshold
Lines 5.32% 🔴
Functions 11.29% 🔴
Branches 26.25% 🔴
Statements 5.32% 🔴

📁 Detailed Coverage by File

File Lines Functions Branches Statements
src/components/Dialogs/DialogProvider/types.ts 100% 100% 100% 100%
src/contexts/NearContext.tsx 7.72% 0% 100% 7.72%
src/hooks/useAnalytics.ts 14.22% 0% 100% 14.22%
src/hooks/useCastVote.ts 98.66% 100% 91.66% 98.66%
src/hooks/useDelegateAll.ts 99.01% 100% 93.75% 99.01%
src/hooks/useDelegates.ts 11.47% 50% 50% 11.47%
src/hooks/useFetchProof.ts 95% 100% 80% 95%
src/hooks/useLockNear.ts 98.27% 100% 85.71% 98.27%
src/hooks/useReadHOSContract.ts 97.67% 100% 87.5% 97.67%
src/hooks/useRefreshStakingPoolBalance.ts 96% 100% 80% 96%
src/hooks/useSelectStakingPool.ts 97.61% 100% 80% 97.61%
src/hooks/useStakeNear.ts 66.66% 100% 93.33% 66.66%
src/hooks/useStakedBalance.ts 11.11% 50% 50% 11.11%
src/hooks/useUndelegate.ts 98.83% 100% 92.85% 98.83%
src/hooks/useUnlockNear.ts 96.66% 100% 80% 96.66%
src/hooks/useUnstakedBalance.ts 6.66% 50% 50% 6.66%
src/hooks/useWriteHOSContract.ts 97.77% 100% 85.71% 97.77%
src/lib/constants.ts 98.21% 0% 0% 98.21%
src/lib/contractConstants.ts 43.85% 100% 22.22% 43.85%
src/lib/proposalMetadata.ts 88.09% 100% 60% 88.09%
📋 Show 20 more files...
File Lines Functions Branches Statements
src/lib/proposalUtils.ts 55.48% 33.33% 50% 55.48%
src/lib/tokenUtils.ts 72.22% 33.33% 100% 72.22%
src/lib/utils.ts 13.39% 3.22% 100% 13.39%
src/lib/analytics/index.ts 40.68% 58.33% 41.17% 40.68%
src/lib/analytics/mixpanel.ts 45.07% 22.22% 40% 45.07%
src/lib/api/constants.ts 75.86% 50% 16.66% 75.86%
src/lib/api/delegates/requests.ts 10.52% 0% 100% 10.52%
src/lib/api/near/types.ts 100% 100% 100% 100%
src/lib/api/nonce/requests.ts 22.22% 0% 100% 22.22%
src/lib/api/nonce/types.ts 100% 100% 100% 100%
src/lib/api/transactions/types.ts 100% 100% 100% 100%
src/lib/contracts/types/common.ts 100% 100% 100% 100%
src/lib/contracts/types/lockup.ts 100% 100% 100% 100%
src/lib/contracts/types/venear.ts 100% 100% 100% 100%
src/lib/contracts/types/voting.ts 90.9% 100% 75% 90.9%
src/lib/tenant/tenant.ts 58.33% 38.46% 100% 58.33%
src/lib/tenant/tenantUI.ts 62.16% 23.52% 71.42% 62.16%
src/lib/tenant/configs/ui/near.ts 99.55% 100% 50% 99.55%
src/lib/wallets/fireblocks-compat.ts 9.67% 0% 100% 9.67%
src/types/nearClaim.ts 100% 100% 100% 100%

Coverage Thresholds:

  • 🟢 Good: ≥80%
  • 🟡 Moderate: 60-79%
  • 🔴 Needs Improvement: <60%

This report was generated by the Test Coverage workflow.

@atomauro atomauro force-pushed the atom/copy-audit-improvements branch from e745ee0 to e55afcb Compare February 10, 2026 16:42
@atomauro atomauro force-pushed the atom/copy-audit-improvements branch from e55afcb to 6cf4e8d Compare February 10, 2026 16:47
@atomauro atomauro marked this pull request as draft February 10, 2026 16:53
@atomauro atomauro force-pushed the atom/copy-audit-improvements branch from 6cf4e8d to 9e17885 Compare February 10, 2026 16:54
@atomauro atomauro marked this pull request as ready for review February 10, 2026 16:59
snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
@snadolny
Copy link
Contributor

snadolny commented Feb 11, 2026

Page 2 of doc says:

Roadmap starts with Alpha Launch, the least current information, which is confusing. This section should be updated to start with current state, outline updated future plans, and then updated reverse chronological release timeline.

But the preview still has alpha launch first and the current implementation section was removed:
image

@snadolny
Copy link
Contributor

snadolny commented Feb 11, 2026 •
edited
Loading

Page 5 of the doc says:

Question: How can I increase my governance rewards?

Current Copy: Your rewards increase based on how much NEAR you lock and how long you lock it for. Please note: The total amount of veNEAR rewards distributed depends on the overall NEAR participation in the rewards campaign. Your individual allocation scales with your lock amount and lock duration.

You can also increase your overall participation rewards by staking NEAR (optional). Combining locking and staking may increase your overall participation rewards, depending on program parameters. For more details on how rewards are calculated, check out this link.

Improvement Needed: We should be able to provide more certainty about whether staking NEAR will boost participation rewards. This should be updated

No copy changes were made here at all:

image

snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
snadolny
snadolny reviewed Feb 11, 2026
View reviewed changes
@snadolny
Copy link
Contributor

snadolny commented Feb 11, 2026

The document also says "Remove all uses of "governance rewards" (undefined, confusing)"

I think we should replace this text in this FAQ:

image

@atomauro
fix(copy): Address all remaining PR review comments
a054ebd 
- I1: LockProvider toast → audit copy (veNEAR + rewards eligibility)
- I2: Lock EnterAmountStep → audit title/subtitle
- I3: DisclosuresContent Disclosure 2 → add LST unstaking cooldown
- I4: EnterStakingAmount → distinguish staking yields from veNEAR rewards
- I5: UnstakeDialog → pool-specific cooldowns (not ~4 days)
- I6: StakingDisclosures Disclosure 3 → CRITICAL: cannot unstake from pool website
- I7: UndelegateDialog → delegate retains VP on pre-existing proposals
- Remove 'governance rewards' from LockTokensCard, GovernanceRewardsCard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@snadolny snadolny snadolny left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@atomauro atomauro

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@atomauro @snadolny