Skip to content

fix(continuous-integration): manage working directory properly #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilime merged 1 commit into from
Nov 22, 2025
Merged

fix(continuous-integration): manage working directory properly #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions actions/build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,25 @@ runs:
WORKING_DIRECTORY: ${{ inputs.working-directory }}
with:
script: |
const fs = require('node:fs');
const path = require('node:path');

const buildCommands = process.env.BUILD_COMMANDS || '';
const runScriptCommand = process.env.RUN_SCRIPT_COMMAND;
const workingDirectory = process.env.WORKING_DIRECTORY || '.';

let workingDirectory = process.env.WORKING_DIRECTORY || '.';
if (!path.isAbsolute(workingDirectory)) {
workingDirectory = path.join(process.env.GITHUB_WORKSPACE, workingDirectory);
}

if (!fs.existsSync(workingDirectory)) {
core.setFailed(`The specified working directory does not exist: ${workingDirectory}`);
return;
}

workingDirectory = path.resolve(workingDirectory);
core.debug(`Running in working directory: ${workingDirectory}`);
process.chdir(workingDirectory);

const commands = buildCommands.split('\n')
.map(cmd => cmd.trim())
Expand All @@ -121,15 +137,14 @@ runs:
core.info(`Running build command: ${command}`);

try {
const result = await exec.getExecOutput(runScriptCommand, [command], {
cwd: require('path').resolve(process.env.GITHUB_WORKSPACE, workingDirectory)
const exitCode = await exec.exec(runScriptCommand, [command], {
cwd: workingDirectory,
ignoreReturnCode: true
});

if (result.stdout) {
core.info(result.stdout);
}
if (result.stderr) {
core.warning(result.stderr);
if(exitCode !== 0) {
core.setFailed(`Build command "${command}" failed with exit code ${exitCode}`);
throw new Error(`Build command "${command}" failed with exit code ${exitCode}`);
}
} catch (error) {
core.setFailed(`Build command "${command}" failed: ${error.message}`);
Expand Down
18 changes: 17 additions & 1 deletion actions/lint/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,26 @@ runs:
LINT_COMMAND: ${{ inputs.command }}
with:
script: |
const workingDirectory = process.env.WORKING_DIRECTORY;
const fs = require('node:fs');
const path = require('node:path');

const runScriptCommand = process.env.RUN_LINT_COMMAND;
const lintCommand = process.env.LINT_COMMAND || 'lint:ci';

let workingDirectory = process.env.WORKING_DIRECTORY || '.';
if (!path.isAbsolute(workingDirectory)) {
workingDirectory = path.join(process.env.GITHUB_WORKSPACE, workingDirectory);
}

if (!fs.existsSync(workingDirectory)) {
core.setFailed(`The specified working directory does not exist: ${workingDirectory}`);
return;
}

workingDirectory = path.resolve(workingDirectory);
core.debug(`Running in working directory: ${workingDirectory}`);
process.chdir(workingDirectory);

core.info(`👕 Running lint command: ${lintCommand}...`);

try {
Expand Down
18 changes: 17 additions & 1 deletion actions/test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,26 @@ runs:
TEST_COMMAND: ${{ inputs.command }}
with:
script: |
const workingDirectory = process.env.WORKING_DIRECTORY;
const fs = require('node:fs');
const path = require('node:path');

const runScriptCommand = process.env.RUN_TEST_COMMAND;
const testCommand = process.env.TEST_COMMAND || 'test:ci';

let workingDirectory = process.env.WORKING_DIRECTORY || '.';
if (!path.isAbsolute(workingDirectory)) {
workingDirectory = path.join(process.env.GITHUB_WORKSPACE, workingDirectory);
}

if (!fs.existsSync(workingDirectory)) {
core.setFailed(`The specified working directory does not exist: ${workingDirectory}`);
return;
}

workingDirectory = path.resolve(workingDirectory);
core.debug(`Running in working directory: ${workingDirectory}`);
process.chdir(workingDirectory);

core.info(`🧪 Running test command: ${testCommand}...`);

try {
Expand Down
Loading