-
Notifications
You must be signed in to change notification settings - Fork 0
fix(test): fix codecov GPG issues in container mode using github-script helpers #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… issues Co-authored-by: neilime <[email protected]>
|
Code Coverage Report Coverage ResultsCoverage
Overall: 100.00% 🟢 |
neilime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot this is stupid workaround, the codecov action requiresbash, curl, git, and gpg (https://github.com/codecov/codecov-action?tab=readme-ov-file#usage), so skipping validation, will just move the issue the step after.
…lidation Co-authored-by: neilime <[email protected]>
You're right. I've revised the fix in d248c7f. Instead of skipping validation, I now:
This keeps all codecov-action dependencies (bash, curl, git, gpg) working correctly. |
Co-authored-by: neilime <[email protected]>
Co-authored-by: neilime <[email protected]>
neilime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot handle feedbacks
…nd GPG fix Co-authored-by: neilime <[email protected]>
af3d9d2 to
f5f2a05
Compare
Co-authored-by: neilime <[email protected]> Signed-off-by: Emilien Escalle <[email protected]>
f5f2a05 to
7cba498
Compare
Fixes the codecov action failing when running tests in container mode due to GPG signature verification issues from pkgxdev-installed gnupg.
Root Cause
pkgxdev/setup installs gnupg with a
gpgconf.ctlfile containing unexpanded environment variables like${GNUPG_BUILD_ROOT:-/github/home/.pkgx/gnupg.org/v2.4.8}/, causing GPG operations to fail.Changes Made
The fix modifies
actions/test/action.ymlto:Check if dependencies exist before installing - Added a "Check and install Codecov dependencies" step using
actions/github-script:io.which()to check if git, curl, and gpg already existFix GPG configuration using GitHub Script helpers - Replaced bash script with
actions/github-script:io.which()to locate the gpgconf binaryio.rmRF()to remove the malformedgpgconf.ctlfileio.mkdirP()to create GNUPGHOME directoryfs.chmodSync()for setting proper permissions (700)This properly fixes the pkgxdev gnupg installation issue while maintaining all codecov-action dependencies (bash, curl, git, gpg).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.