-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(test): extract Codecov logic to dedicated action with config fixes #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable Co-authored-by: neilime <[email protected]>
Co-authored-by: neilime <[email protected]>
Copilot
AI
changed the title
[WIP] Fix variable expansion issue in action.yml
fix(test): handle unexpanded SSL_CERT_FILE in pkgxdev curl config
Nov 30, 2025
Contributor
|
Code Coverage Report Coverage ResultsCoverage
Overall: 100.00% 🟢 |
neilime
requested changes
Nov 30, 2025
Member
neilime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot handle feedbacks
Co-authored-by: neilime <[email protected]>
Contributor
Author
Copilot
AI
changed the title
fix(test): handle unexpanded SSL_CERT_FILE in pkgxdev curl config
refactor(test): extract Codecov logic to dedicated action with config fixes
Nov 30, 2025
neilime
requested changes
Nov 30, 2025
Member
neilime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot handle feedbacks
Contributor
Author
Co-authored-by: neilime <[email protected]> Signed-off-by: Emilien Escalle <[email protected]>
9f33458 to
d245700
Compare
neilime
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pkgxdev installs curl for Codecov dependencies, it creates a
.curlrcwith unexpanded shell variables like${SSL_CERT_FILE:-/github/home/.pkgx/curl.se/ca-certs/...}. This mirrors the existing gpgconf.ctl issue.Changes
actions/codecov/action.yml- dedicated action for Codecov integrationactions/test/action.ymlto the new action.curlrcwhen curl is installed via pkgxdevgpgconf.ctlactions/codecov/README.mddocumentationREADME.mdto include the new codecov actionNew Codecov Action Features
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.