Skip to content

feat: add hk-deployment argocd CMP#59

Merged
neilime merged 4 commits intomainfrom
feat/argocd-cmp-hk-deployment
Nov 30, 2025
Merged

feat: add hk-deployment argocd CMP#59
neilime merged 4 commits intomainfrom
feat/argocd-cmp-hk-deployment

Conversation

@fredleger
Copy link
Contributor

@fredleger fredleger commented Nov 21, 2025

Provide a docker image used as argocd CMP plugin in hoverkraft

@fredleger fredleger force-pushed the feat/argocd-cmp-hk-deployment branch from 1b119e7 to 3f32560 Compare November 21, 2025 14:04
@fredleger fredleger requested a review from neilime November 21, 2025 14:05
@fredleger
Copy link
Contributor Author

@neilime je te passe la main sur la partie CI

@neilime neilime force-pushed the feat/argocd-cmp-hk-deployment branch 6 times, most recently from 502c2ff to 3cdc8e8 Compare November 26, 2025 06:28
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

Built Images Summary

Image Tags Platforms Digest
ghcr.io/hoverkraft-tech/docker-base-images/argocd-cmp-hk-deployment pr-59-7027159, pr-59 linux/amd64, linux/arm64 sha256:2cab2389f8eae...

Image Details

argocd-cmp-hk-deployment

Pull command:

docker pull ghcr.io/hoverkraft-tech/docker-base-images/argocd-cmp-hk-deployment:pr-59-7027159@sha256:2cab2389f8eae2526d576987c4de88fedd5da2515f70580f792335a02a92b434

Full image references:

  • ghcr.io/hoverkraft-tech/docker-base-images/argocd-cmp-hk-deployment:pr-59-7027159@sha256:2cab2389f8eae2526d576987c4de88fedd5da2515f70580f792335a02a92b434
  • ghcr.io/hoverkraft-tech/docker-base-images/argocd-cmp-hk-deployment:pr-59@sha256:2cab2389f8eae2526d576987c4de88fedd5da2515f70580f792335a02a92b434

Annotations:

@neilime neilime force-pushed the feat/argocd-cmp-hk-deployment branch from 3cdc8e8 to 2e161ca Compare November 26, 2025 15:44
@neilime neilime force-pushed the feat/argocd-cmp-hk-deployment branch 2 times, most recently from 539fb8e to 6ecef81 Compare November 27, 2025 16:30
@neilime
Copy link
Member

neilime commented Nov 27, 2025

@fredleger CI/CD is released!

I've made a commit to fix lint issues, I let you reivew that

Bonus:

@fredleger
Copy link
Contributor Author

@neilime can you review last changes please ?

@fredleger
Copy link
Contributor Author

@neilime can you see about the tests folder place ?

@neilime neilime force-pushed the feat/argocd-cmp-hk-deployment branch 3 times, most recently from a621211 to 5c5b3b2 Compare November 28, 2025 14:24
@fredleger
Copy link
Contributor Author

@neilime l'image tourne au poil. Merge qd tu veux

@fredleger
Copy link
Contributor Author

@neilime in case you are working to the tests in another branch (which i think you do), i changed the approach and thus the tests (see Taskfile). Now we have a single image with 2 scripts that are able to handle all the argocd cases. Basically that means that :

  • The entrypoint script of the existing test (single source) has changed
  • There is 2 new tests cases for the multi-sources

@fredleger fredleger force-pushed the feat/argocd-cmp-hk-deployment branch from c25e1eb to 3f92204 Compare November 29, 2025 09:48
@neilime
Copy link
Member

neilime commented Nov 29, 2025

FYI the PR to introduce testing: #109

I've chosen google container-test instead of testcontainers because test containers introduce complexity in term of devx

@fredleger
Copy link
Contributor Author

Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
neilime and others added 2 commits November 30, 2025 23:14
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime neilime force-pushed the feat/argocd-cmp-hk-deployment branch from 3f92204 to 9fb2bc0 Compare November 30, 2025 22:14
Signed-off-by: Emilien Escalle <emilien.escalle@escemi.com>
@neilime neilime force-pushed the feat/argocd-cmp-hk-deployment branch from 9fb2bc0 to 3ca40c8 Compare November 30, 2025 22:31
@github-actions
Copy link
Contributor

Code Coverage Report

Test Results - argocd-cmp-hk-deployment

Test Results

Status Count
✅ Passed 8
❌ Failed 0
⏭️ Skipped 0
Total 8

Pass Rate: 100.0%

@neilime neilime merged commit b47d749 into main Nov 30, 2025
38 checks passed
@neilime neilime deleted the feat/argocd-cmp-hk-deployment branch November 30, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants