feat(github): add repository, ruleset, and branch protection rule#64
Merged
feat(github): add repository, ruleset, and branch protection rule#64
Conversation
Contributor
fredleger
commented
Feb 12, 2025
fredleger
commented
- feat: add github repository
- feat: add github repo branch protection rules
- chore: enforce defaults
- fix: minor fixes
- feat: add team admins var
- feat(github): add repository ruleset
Contributor
Author
|
this will produce the example repo config: https://github.com/cigales-cloud/test/settings |
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 27 changed files in this pull request and generated 3 comments.
Files not reviewed (16)
- github/branch-protection/.terraform.lock.hcl: Language not supported
- github/branch-protection/.tflint.hcl: Language not supported
- github/branch-protection/.tool-versions: Language not supported
- github/branch-protection/gh-branch-protection.tf: Language not supported
- github/branch-protection/main.tf: Language not supported
- github/branch-protection/providers.tf: Language not supported
- github/branch-protection/variables.tf: Language not supported
- github/repository-ruleset/.terraform.lock.hcl: Language not supported
- github/repository-ruleset/.tflint.hcl: Language not supported
- github/repository-ruleset/.tool-versions: Language not supported
- github/repository-ruleset/gh-repo-ruleset.tf: Language not supported
- github/repository-ruleset/main.tf: Language not supported
- github/repository-ruleset/providers.tf: Language not supported
- github/repository-ruleset/variables.tf: Language not supported
- github/repository/.terraform.lock.hcl: Language not supported
- github/repository/.tflint.hcl: Language not supported
Comments suppressed due to low confidence (2)
github/repository-ruleset/README.md:62
- [nitpick] The variable name 'bypass_actors' is ambiguous. It should be renamed to 'allowed_bypass_actors'.
[bypass_actors](#input_bypass_actors) | List of actors allowed to bypass this ruleset | `list(any)` | <pre>[<br> {<br> "actor_id": 0,<br> "actor_type": "OrganizationAdmin",<br> "bypass_mode": "always"<br> },<br> {<br> "actor_id": 5,<br> "actor_type": "RepositoryRole",<br> "bypass_mode": "always"<br> },<br> {<br> "actor_id": 11722557,<br> "actor_type": "Team",<br> "bypass_mode": "always"<br> }<br>]</pre> | no
github/repository-ruleset/README.md:65
- [nitpick] The enforcement type 'evaluate' should be 'evaluating' for consistency.
[enforcement](#input_enforcement) | The type of enforcement (disabled, active, evaluate) | `string` | "active" | no
fredleger
force-pushed
the
feat/github-repos
branch
from
a9dd083 to
7252bda
Compare
fredleger
changed the title
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 27 changed files in this pull request and generated 5 comments.
Files not reviewed (16)
- github/branch-protection/.terraform.lock.hcl: Language not supported
- github/branch-protection/.tflint.hcl: Language not supported
- github/branch-protection/.tool-versions: Language not supported
- github/branch-protection/gh-branch-protection.tf: Language not supported
- github/branch-protection/main.tf: Language not supported
- github/branch-protection/providers.tf: Language not supported
- github/branch-protection/variables.tf: Language not supported
- github/repository-ruleset/.terraform.lock.hcl: Language not supported
- github/repository-ruleset/.tflint.hcl: Language not supported
- github/repository-ruleset/.tool-versions: Language not supported
- github/repository-ruleset/gh-repo-ruleset.tf: Language not supported
- github/repository-ruleset/main.tf: Language not supported
- github/repository-ruleset/providers.tf: Language not supported
- github/repository-ruleset/variables.tf: Language not supported
- github/repository/.terraform.lock.hcl: Language not supported
- github/repository/.tflint.hcl: Language not supported
fredleger
force-pushed
the
feat/github-repos
branch
3 times, most recently
from
e7ff200 to
b494316
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 27 changed files in this pull request and generated 2 comments.
Files not reviewed (16)
- github/branch-protection/.terraform.lock.hcl: Language not supported
- github/branch-protection/.tflint.hcl: Language not supported
- github/branch-protection/.tool-versions: Language not supported
- github/branch-protection/gh-branch-protection.tf: Language not supported
- github/branch-protection/main.tf: Language not supported
- github/branch-protection/providers.tf: Language not supported
- github/branch-protection/variables.tf: Language not supported
- github/repository-ruleset/.terraform.lock.hcl: Language not supported
- github/repository-ruleset/.tflint.hcl: Language not supported
- github/repository-ruleset/.tool-versions: Language not supported
- github/repository-ruleset/gh-repo-ruleset.tf: Language not supported
- github/repository-ruleset/main.tf: Language not supported
- github/repository-ruleset/providers.tf: Language not supported
- github/repository-ruleset/variables.tf: Language not supported
- github/repository/.terraform.lock.hcl: Language not supported
- github/repository/.tflint.hcl: Language not supported
Comments suppressed due to low confidence (1)
github/repository-ruleset/README.md:7
- The term 'GitHub app' should be 'GitHub app'.
you must create a GitHub app or a classic token with admin rights
fredleger
force-pushed
the
feat/github-repos
branch
from
b494316 to
109baaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.