feat: switch to ovh provider for private subnet#84
Merged
fredleger merged 7 commits intohoverkraft-tech:mainfrom Mar 17, 2026
Merged
feat: switch to ovh provider for private subnet#84fredleger merged 7 commits intohoverkraft-tech:mainfrom
fredleger merged 7 commits intohoverkraft-tech:mainfrom
Conversation
7b230e7 to
406e585
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Switches the ovh/pci-private-subnet Terraform module from managing subnets via the OpenStack provider to using the OVH provider’s ovh_cloud_project_network_private_subnet resource.
Changes:
- Replaced the OpenStack subnet resource with the OVH private subnet resource and updated outputs accordingly.
- Updated module inputs to match OVH subnet arguments (project/service name, region, CIDR, allocation range, DHCP/gateway toggles).
- Removed the OpenStack provider requirement and bumped the OVH provider constraint; updated generated README tables.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| ovh/pci-private-subnet/variables.tf | Reworked inputs for OVH subnet resource (project id, region, CIDR, start/end, DHCP flags). |
| ovh/pci-private-subnet/providers.tf | Dropped OpenStack provider and updated OVH provider version constraint. |
| ovh/pci-private-subnet/private-subnet.tf | Switched resource implementation from OpenStack subnet to OVH private subnet. |
| ovh/pci-private-subnet/outputs.tf | Updated outputs to reference the OVH subnet resource attributes. |
| ovh/pci-private-subnet/README.md | Updated generated provider/resource/input tables for OVH provider usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fredleger
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.