Skip to content

fix for issue with source_download set to latest #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

fix for issue with source_download set to latest #752

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4c8c3a0
fix for issue with source_download set to latest
debonisd Mar 1, 2024
85f58b4
need to unlink the original file
debonisd Mar 4, 2024
fbd1320
Revert "need to unlink the original file"
debonisd Mar 5, 2024
02fba19
Revert "fix for issue with source_download set to latest"
debonisd Mar 5, 2024
146a5f6
Merge branch 'master' into source-download
Paul-Ferrell Mar 14, 2024
e28da6f
Merge branch 'master' into source-download
Paul-Ferrell Mar 21, 2024
72f9a64
inverted logic (or vs and in not)
debonisd Mar 21, 2024
395eae0
fix for source download logic and tests for wget
debonisd Mar 21, 2024
334cdef
Merge branch 'master' into source-download
Paul-Ferrell Mar 21, 2024
f514392
debugging CI
debonisd Mar 21, 2024
7a39cd9
continue testing
debonisd Mar 21, 2024
b4e5e21
debug
debonisd Mar 21, 2024
ae10e8a
debug
debonisd Mar 21, 2024
82605ce
fix for source download was issue with header caching
debonisd Mar 21, 2024
80c40b1
Merge branch 'develop' into source-download
Paul-Ferrell Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pavilion/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def _update_src(self):

if (src_url is not None
and ((src_download == 'missing' and found_src_path is None)
or src_download == 'latest')):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've just changed the behavior of 'latest' such that it is now doing the same as 'missing'. That's not the problem. It seems that the files are getting downloaded, but they're not getting copied into their expected destination where Pavilion can find them.

or src_download == 'latest' and found_src_path is None)):

if self._download_dest is None:
raise TestBuilderError(
Expand Down