HPCC-35552 Improve logging when async connect fails#20786
HPCC-35552 Improve logging when async connect fails#20786ghalliday merged 1 commit intohpcc-systems:candidate-10.2.xfrom
Conversation
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
|
E.g. |
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35552 Jirabot Action Result: |
There was a problem hiding this comment.
Pull request overview
This PR improves error logging when asynchronous socket connections fail by adding a new utility function and enhanced error messages that include the target endpoint and the specific error cause.
Key Changes:
- Added
getSocketErrorMessage()function to expose socket error message formatting - Enhanced connection failure logging with endpoint and error details in async connect callback
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| system/jlib/jsocket.hpp | Declares new getSocketErrorMessage() function to expose error message formatting |
| system/jlib/jsocket.cpp | Implements getSocketErrorMessage() wrapper around existing SocketException error formatting |
| system/security/securesocket/socketutils.cpp | Adds detailed error logging when async connect/reconnect fails, including endpoint and error cause |
|
I had delayed merging this until I had thought about the connection failure case. Opened a new jira to discuss/address. |
6ce858e
into
hpcc-systems:candidate-10.2.x
|
Jirabot Action Result: |
Type of change:
Checklist:
Smoketest:
Testing: