Skip to content

Conversation

@GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 7, 2026

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copilot AI review requested due to automatic review settings January 7, 2026 09:30
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35525

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Global Metrics page to the ECL Watch web interface, providing visibility into system-wide metrics with date range filtering capabilities. The implementation includes routing, menu integration, localization support, and updates to webpack configuration and dependencies.

Key Changes:

  • New GlobalMetrics React component with date range filtering and grid display of normalized metrics
  • Updated webpack configuration to improve source map generation and module handling
  • Enhanced formatCost function to support unit offset for flexible cost calculations

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
esp/src/webpack.config.js Removed "use strict" removal plugin, updated source-map-loader test pattern to include .mjs/.cjs files, changed devtool to full "source-map" for better debugging
esp/src/src/Session.ts Added optional unitOffset parameter to formatCost function for flexible cost unit adjustments
esp/src/src-react/routes.tsx Added /global-stats routes under both topology and operations sections
esp/src/src-react/hooks/diskUsage.ts Removed unused XREFDirectories interface and WsDFUXRefEx import
esp/src/src-react/components/Menu.tsx Added GlobalMetrics menu items to topology and operations submenus
esp/src/src-react/components/GlobalMetrics.tsx New component implementing global metrics page with date picker controls, data grid, and custom formatters for durations and costs
esp/src/src-dojo/nls/*/hpcc.ts Added "Dimensions" and "GlobalMetrics" localization entries across all language files
esp/src/package.json Updated @hpcc-js dependencies to newer versions (chart 3.6.1, comms 3.13.0, etc.)

@GordonSmith GordonSmith force-pushed the HPCC-35525-GLOBAL_STATS branch from dc98388 to 2f94f9b Compare January 7, 2026 10:10
@GordonSmith GordonSmith force-pushed the HPCC-35525-GLOBAL_STATS branch from 2f94f9b to 704af86 Compare January 7, 2026 10:24
@GordonSmith GordonSmith requested a review from jeclrsg January 7, 2026 11:17
@GordonSmith
Copy link
Member Author

@ghalliday this is a rudimentary implementation so we can look at the data - my test data was very sparse to say the least...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant