-
Notifications
You must be signed in to change notification settings - Fork 311
HPCC-35525 Add rudimentary Global Metrics page #20805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: candidate-10.0.x
Are you sure you want to change the base?
HPCC-35525 Add rudimentary Global Metrics page #20805
Conversation
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35525 Jirabot Action Result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new Global Metrics page to the ECL Watch web interface, providing visibility into system-wide metrics with date range filtering capabilities. The implementation includes routing, menu integration, localization support, and updates to webpack configuration and dependencies.
Key Changes:
- New GlobalMetrics React component with date range filtering and grid display of normalized metrics
- Updated webpack configuration to improve source map generation and module handling
- Enhanced
formatCostfunction to support unit offset for flexible cost calculations
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| esp/src/webpack.config.js | Removed "use strict" removal plugin, updated source-map-loader test pattern to include .mjs/.cjs files, changed devtool to full "source-map" for better debugging |
| esp/src/src/Session.ts | Added optional unitOffset parameter to formatCost function for flexible cost unit adjustments |
| esp/src/src-react/routes.tsx | Added /global-stats routes under both topology and operations sections |
| esp/src/src-react/hooks/diskUsage.ts | Removed unused XREFDirectories interface and WsDFUXRefEx import |
| esp/src/src-react/components/Menu.tsx | Added GlobalMetrics menu items to topology and operations submenus |
| esp/src/src-react/components/GlobalMetrics.tsx | New component implementing global metrics page with date picker controls, data grid, and custom formatters for durations and costs |
| esp/src/src-dojo/nls/*/hpcc.ts | Added "Dimensions" and "GlobalMetrics" localization entries across all language files |
| esp/src/package.json | Updated @hpcc-js dependencies to newer versions (chart 3.6.1, comms 3.13.0, etc.) |
dc98388 to
2f94f9b
Compare
Signed-off-by: Gordon Smith <[email protected]>
2f94f9b to
704af86
Compare
|
@ghalliday this is a rudimentary implementation so we can look at the data - my test data was very sparse to say the least... |
Type of change:
Checklist:
Smoketest:
Testing: