HPCC-35501 Metrics timeline maintain zoom #20809
Conversation
Signed-off-by: Panagiotatos <[email protected]>
Signed-off-by: Tim Klemm <[email protected]>
Add evtool index summarize option -s to generate one row of summary data per unique service name. Events recorded without a trace ID or recorded outside the scope of balanced QueryStart and QueryEnd events are grouped together. Signed-off-by: Tim Klemm <[email protected]>
…tspot-file-suppression HPCC-35563: Suppress inactive files from evtool index hotspot output Reviewed-by: Gavin Halliday <[email protected]> Merged-by: Gavin Halliday <[email protected]>
Without the ALL flag, fields with empty strings were omitted entirely from the output. Signed-off-by: Dan S. Camper <[email protected]>
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35501 Jirabot Action Result: |
There was a problem hiding this comment.
Pull request overview
This PR enhances the ECL Watch v9 WU Details page's Metrics timeline by maintaining user-defined zoom levels when the metrics are refreshed, instead of resetting to fit all elements.
Key Changes
- Adds
.preserveZoom(true)configuration to the gantt chart in the WUTimelinePatched class - Updates
@hpcc-js/timelinepackage from version 3.2.2 to 3.3.0 to support the new preserveZoom feature - Updates transitive dependencies in package-lock.json as part of the timeline package upgrade
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| esp/src/src/Timings.ts | Adds .preserveZoom(true) method call to the gantt chart configuration to maintain zoom state on refresh |
| esp/src/package.json | Updates @hpcc-js/timeline dependency from 3.2.2 to 3.3.0 |
| esp/src/package-lock.json | Updates lockfile entries for @hpcc-js/timeline and its transitive dependencies to support the new version |
The changes are well-focused and appropriate for the stated goal. The code change is minimal (adding a single configuration line), and the package update is a minor version bump that provides the necessary preserveZoom API. The transitive dependency updates in the lock file are standard for this type of package upgrade and include updates to @hpcc-js/api, @hpcc-js/chart, @hpcc-js/common, @hpcc-js/dgrid, @hpcc-js/html, @hpcc-js/layout, @hpcc-js/react, and @hpcc-js/util packages.
Files not reviewed (1)
- esp/src/package-lock.json: Language not supported
Signed-off-by: Jim DeFabia <[email protected]>
GordonSmith
left a comment
GordonSmith
left a comment
There was a problem hiding this comment.
Code looks good, it could probably target 10.0.x?
…notrim HPCC-23274 Support TOJSON(,ALL) and TOXML(,ALL) Reviewed-by: Gavin Halliday <[email protected]> Merged-by: Gavin Halliday <[email protected]>
…mmarize-servicename HPCC-35418: Summarize events by service name Reviewed-by: Gavin Halliday <[email protected]> Merged-by: Gavin Halliday <[email protected]>
…_TOJSON_TOXML HPCC-35582 Document ALL flag for TOXML & TOJSON functions Reviewed-By: Dan S. Camper <[email protected]> Merged-by: Gavin Halliday <[email protected]>
HPCC-35555 Update version.xml information Reviewed-By: Jim DeFabia <[email protected]> Merged-by: Gavin Halliday <[email protected]>
changes the ECL Watch v9 WU Details page's Metrics timeline so that when the timeline is zoomed, refreshing the metrics will retain this user-defined zoom instead of reverting the zoom to fit all elements Signed-off-by: Jeremy Clements <[email protected]>
jeclrsg
force-pushed
the
hpcc-35501-metrics-timeline-perserve-zoom
branch
from
b62d329 to
df1a187
Compare
5 participants
changes the ECL Watch v9 WU Details page's Metrics timeline so that when the timeline is zoomed, refreshing the metrics will retain this user-defined zoom instead of reverting the zoom to fit all elements
Type of change:
Checklist:
Smoketest:
Testing: