Skip to content

HPCC-22137 ECL Watch v9 ZAP import#21039

Open
jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
jeclrsg:hpcc-22137-zap-import
Open

HPCC-22137 ECL Watch v9 ZAP import#21039
jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
jeclrsg:hpcc-22137-zap-import

Conversation

@jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Feb 27, 2026

  • adds support for importing a WU via a ZAP report zip file
  • extracts the xhr-based upload functionality from FileListForm (which provides upload progress) into a reusable hook
  • fixed the Landing Zone upload input's default file filter
  • updated react-coding instructions to indicate where the localization files can be found

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copilot AI review requested due to automatic review settings February 27, 2026 15:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for importing workunits via ZAP report zip files to ECL Watch v9. The implementation extracts file upload functionality into a reusable hook and fixes a file filter issue in the Landing Zone component.

Changes:

  • Created a reusable useFileUpload hook that handles XHR-based file uploads with progress tracking
  • Implemented a new ZAPImport component for importing ZAP report archives
  • Fixed the Landing Zone file input filter to use proper format

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
esp/src/src-react/hooks/useFileUpload.ts New reusable hook for file uploads with progress tracking
esp/src/src-react/hooks/index.ts Exports the new useFileUpload hook
esp/src/src-react/components/forms/landing-zone/FileListForm.tsx Refactored to use the new useFileUpload hook
esp/src/src-react/components/forms/ZAPImport.tsx New component for importing ZAP archives
esp/src/src-react/components/Workunits.tsx Integrates ZAPImport component with Import button
esp/src/src-react/components/LandingZone.tsx Fixed file filter format from wildcard to proper extensions
esp/src/src-dojo/nls/hpcc.ts Added localization string for ZAP file selection
esp/src/.github/instructions/react-coding.instructions.md Documented localization file locations

@jeclrsg jeclrsg force-pushed the hpcc-22137-zap-import branch from e4f877d to 3fca1e8 Compare February 27, 2026 15:26
@jeclrsg jeclrsg requested a review from GordonSmith February 27, 2026 15:26
@github-actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-22137

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment re the Fluent UI event hook, which might make your upload file hook a little cleaner?

* adds support for importing a WU via a ZAP report zip file
* extracts the xhr-based upload functionality from FileListForm (which
  provides upload progress) into a reusable hook
* fixed the Landing Zone upload input's default file filter
* updated react-coding instructions to indicate where the localization
  files can be found

Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
@jeclrsg jeclrsg force-pushed the hpcc-22137-zap-import branch from 3fca1e8 to 7d39978 Compare March 6, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants