HPCC-22137 ECL Watch v9 ZAP import#21039
Open
jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for importing workunits via ZAP report zip files to ECL Watch v9. The implementation extracts file upload functionality into a reusable hook and fixes a file filter issue in the Landing Zone component.
Changes:
- Created a reusable
useFileUploadhook that handles XHR-based file uploads with progress tracking - Implemented a new
ZAPImportcomponent for importing ZAP report archives - Fixed the Landing Zone file input filter to use proper format
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
esp/src/src-react/hooks/useFileUpload.ts |
New reusable hook for file uploads with progress tracking |
esp/src/src-react/hooks/index.ts |
Exports the new useFileUpload hook |
esp/src/src-react/components/forms/landing-zone/FileListForm.tsx |
Refactored to use the new useFileUpload hook |
esp/src/src-react/components/forms/ZAPImport.tsx |
New component for importing ZAP archives |
esp/src/src-react/components/Workunits.tsx |
Integrates ZAPImport component with Import button |
esp/src/src-react/components/LandingZone.tsx |
Fixed file filter format from wildcard to proper extensions |
esp/src/src-dojo/nls/hpcc.ts |
Added localization string for ZAP file selection |
esp/src/.github/instructions/react-coding.instructions.md |
Documented localization file locations |
e4f877d to
3fca1e8
Compare
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-22137 Jirabot Action Result: |
GordonSmith
requested changes
Mar 6, 2026
Member
GordonSmith
left a comment
There was a problem hiding this comment.
One comment re the Fluent UI event hook, which might make your upload file hook a little cleaner?
* adds support for importing a WU via a ZAP report zip file * extracts the xhr-based upload functionality from FileListForm (which provides upload progress) into a reusable hook * fixed the Landing Zone upload input's default file filter * updated react-coding instructions to indicate where the localization files can be found Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
3fca1e8 to
7d39978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
Checklist:
Smoketest:
Testing: