HPCC-35931 Containerized builds missing authn vault in component config#21056
Open
kenrowland wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
Open
HPCC-35931 Containerized builds missing authn vault in component config#21056kenrowland wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
kenrowland wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
Conversation
Added code to copy the authn vault into the component config Signed-Off-By: Kenneth Rowland kenneth.rowland@lexisnexisrisk.com
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35931 Jirabot Action Result: |
asselitx
approved these changes
Mar 4, 2026
Contributor
Author
|
@ghalliday please merge |
ghalliday
reviewed
Mar 6, 2026
Member
ghalliday
left a comment
There was a problem hiding this comment.
The jira needs to contain a summary of the change in the conclusion.
This does not look like the correct approach. Rather than merging into the global config, shouldn't the secret code also iterate the global config and add vaults that it finds there?
Otherwise there is potential for problems when these are dynamically updated (although the vault code does not currently support that).
Contributor
Author
|
Added statement in conclusion for Jira. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to copy the authn vault into the component config
Signed-Off-By: Kenneth Rowland kenneth.rowland@lexisnexisrisk.com
Type of change:
Checklist:
Smoketest:
Testing: