Skip to content

HPCC-35868 Ensure graphs have an end time for metrics#21069

Open
GordonSmith wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
GordonSmith:HPCC-35868-ACTIVE_FAILED_GRAPHENDTIME
Open

HPCC-35868 Ensure graphs have an end time for metrics#21069
GordonSmith wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
GordonSmith:HPCC-35868-ACTIVE_FAILED_GRAPHENDTIME

Conversation

@GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Mar 5, 2026

Mark on failure, fake one for running

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested review from Copilot and jakesmith March 5, 2026 12:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures that graphs have an end time for metrics tracking, addressing two scenarios: recording graph elapsed time and finish timestamp on failure in the Thor job manager, and handling missing WhenFinished/TimeElapsed values in the ESP timeline UI by falling back to the current time for still-running graphs.

Changes:

  • In the Thor master graph manager, record graph elapsed time and finish timestamp when an exception occurs during graph execution.
  • In the ESP timeline TypeScript code, relax the filter to no longer require WhenFinished or TimeElapsed, and fall back to the current time if neither is available.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
thorlcr/master/thgraphmanager.cpp Add try/catch block in the exception handler to record graph elapsed time and finish timestamp on failure.
esp/src/src/Timings.ts Relax scope filter and add fallback to current time when WhenFinished and TimeElapsed are both absent.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35868

Jirabot Action Result:
Assigning user: gordon.smith@lexisnexisrisk.com
Workflow Transition To: Merge Pending
Updated PR

Mark on failure, fake one for running

Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
@GordonSmith GordonSmith force-pushed the HPCC-35868-ACTIVE_FAILED_GRAPHENDTIME branch from 574d11d to c4c9027 Compare March 6, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants