HPCC-35868 Ensure graphs have an end time for metrics#21069
Open
GordonSmith wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
Open
HPCC-35868 Ensure graphs have an end time for metrics#21069GordonSmith wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
GordonSmith wants to merge 1 commit intohpcc-systems:candidate-10.2.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that graphs have an end time for metrics tracking, addressing two scenarios: recording graph elapsed time and finish timestamp on failure in the Thor job manager, and handling missing WhenFinished/TimeElapsed values in the ESP timeline UI by falling back to the current time for still-running graphs.
Changes:
- In the Thor master graph manager, record graph elapsed time and finish timestamp when an exception occurs during graph execution.
- In the ESP timeline TypeScript code, relax the filter to no longer require
WhenFinishedorTimeElapsed, and fall back to the current time if neither is available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| thorlcr/master/thgraphmanager.cpp | Add try/catch block in the exception handler to record graph elapsed time and finish timestamp on failure. |
| esp/src/src/Timings.ts | Relax scope filter and add fallback to current time when WhenFinished and TimeElapsed are both absent. |
You can also share your feedback on Copilot code review. Take the survey.
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-35868 Jirabot Action Result: |
Mark on failure, fake one for running Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
574d11d to
c4c9027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark on failure, fake one for running
Type of change:
Checklist:
Smoketest:
Testing: