HPCC-34894 ECL Watch v9 change WU Helpers downloads#21074
Open
jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
Open
HPCC-34894 ECL Watch v9 change WU Helpers downloads#21074jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
jeclrsg wants to merge 1 commit intohpcc-systems:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ECL Watch’s WU Helpers downloads to use the /WsWorkunits/WUHelperFileArchive endpoint (single archive download) and includes a couple of eslint-related cleanups.
Changes:
- Switch Zip/GZip actions in WU Helpers to POST to
/WsWorkunits/WUHelperFileArchiveand download the returned archive blob. - Refactor WorkunitsDashboard data transforms to use
pipeinstead ofchainand tighten some typings. - Minor eslint/format fixes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| esp/src/src-react/components/forms/Fields.tsx | Small formatting/lint fix (semicolon). |
| esp/src/src-react/components/WorkunitsDashboard.tsx | Refactors dataflow pipelines from chain to pipe and adjusts typing. |
| esp/src/src-react/components/Helpers.tsx | Implements archive-based helper downloads via POST + blob download, updates command bar buttons. |
d0f66eb to
9a7ce72
Compare
* changed the Zip and Gzip buttons on the WU Helpers page to make use of /WsWorkunits/WUHelperFileArchive rather than opening separate tabs to download each file individually * also fixed an unrelated eslint error Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
9a7ce72 to
ebec7ed
Compare
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-34894 Jirabot Action Result: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends upon #21053
Type of change:
Checklist:
Smoketest:
Testing: