Skip to content

Conversation

@jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented May 7, 2025

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith May 7, 2025 18:49
@GordonSmith GordonSmith requested a review from Copilot May 28, 2025 13:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the WsLogAccess wsdl to version 1.08. It updates import paths to use the new v1.08 implementation and adjusts the service utilities accordingly.

  • Updated service version string derivation in the utils module.
  • Added a new ws_logaccess implementation under v1.08.
  • Updated the import reference in the wsLogaccess service file.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/comms/utils/index.ts Updated serviceVersion by removing the nullish fallback.
packages/comms/src/services/wsdl/ws_logaccess/v1.08/ws_logaccess.ts New ws_logaccess implementation with version bump but constructor still hardcodes "1.07".
packages/comms/src/services/wsLogaccess.ts Updated import path from v1.05 to v1.08.

@GordonSmith
Copy link
Member

@jeclrsg the copilot comments seem reasonable - is the version issue a generator issue?

@jeclrsg jeclrsg force-pushed the bump-ws-logaccess-1.08 branch from 317ca0b to 1296b80 Compare May 29, 2025 13:30
@jeclrsg
Copy link
Contributor Author

jeclrsg commented May 29, 2025

@jeclrsg the copilot comments seem reasonable - is the version issue a generator issue?

It isn't. Rodrigo changed his feature branch to include a new version number for the service. So I must admit I didn't pull the branch, recompile and rerun the wsdl parser, I just edited my PR by hand and missed that second instance of the version number.

@GordonSmith GordonSmith merged commit 2fe055c into hpcc-systems:candidate-2.x.x May 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants